tests/GLProgramsTest.cpp - Issue 766653008: Revert of Make all blending up to GrOptDrawState be handled by the xp/xp factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/GLProgramsTest.cpp

Issue 766653008: Revert of Make all blending up to GrOptDrawState be handled by the xp/xp factory. (Closed) Base URL: https://skia.googlesource.com/skia.git@xferFactorySolo

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/GLProgramsTest.cpp

diff --git a/tests/GLProgramsTest.cpp b/tests/GLProgramsTest.cpp

index 56707a04140e34b4744a815179f309189b8d4217..18c14c45be477f310db42639ce4091505fe766b1 100644

--- a/tests/GLProgramsTest.cpp

+++ b/tests/GLProgramsTest.cpp

@@ -16,12 +16,10 @@

#include "GrInvariantOutput.h"

#include "GrOptDrawState.h"

#include "GrTest.h"

-#include "GrXferProcessor.h"

#include "SkChecksum.h"

#include "SkRandom.h"

#include "Test.h"

#include "effects/GrConfigConversionEffect.h"

-#include "effects/GrPorterDuffXferProcessor.h"

#include "gl/GrGLPathRendering.h"

#include "gl/GrGpuGL.h"

#include "gl/builders/GrGLProgramBuilder.h"

@@ -269,8 +267,7 @@

dst = GrBlendCoeff(random->nextRangeU(kFirstPublicGrBlendCoeff, kLastPublicGrBlendCoeff));

} while (GrBlendCoeffRefsDst(dst));

- GrXPFactory* xpFactory = GrPorterDuffXPFactory::Create(src, dst);

- ds->setXPFactory(xpFactory)->unref();

+ ds->setBlendFunc(src, dst);

}

// right now, the only thing we seem to care about in drawState's stencil is 'doesWrite()'

« no previous file with comments | « src/gpu/effects/GrPorterDuffXferProcessor.cpp ('k') | no next file » | no next file with comments »