Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

chrome/browser/ui/views/location_bar/bubble_icon_view.cc

Index: chrome/browser/ui/views/location_bar/bubble_icon_view.cc
diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
index d74f32937b6aa3edd0a181bb149c653e97b45caf..c74174ec54eb33a8f49017be41cd9f54f34618f3 100644
--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
@@ -5,12 +5,16 @@
 #include "chrome/browser/ui/views/location_bar/bubble_icon_view.h"
 
 #include "chrome/browser/command_updater.h"
+#include "chrome/browser/ui/browser_commands.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/events/event.h"
 
-BubbleIconView::BubbleIconView(CommandUpdater* command_updater, int command_id)
+BubbleIconView::BubbleIconView(CommandUpdater* command_updater,
+                               int command_id,
+                               Browser* browser)
     : command_updater_(command_updater),
       command_id_(command_id),
+      browser_(browser),
       suppress_mouse_released_action_(false) {
   SetAccessibilityFocusable(true);
 }
@@ -71,6 +75,6 @@ void BubbleIconView::OnGestureEvent(ui::GestureEvent* event) {
 
 void BubbleIconView::ExecuteCommand(ExecuteSource source) {
   OnExecuting(source);
-  if (command_updater_)
-    command_updater_->ExecuteCommand(command_id_);
+  if (browser_)
+    chrome::BookmarkCurrentPageInternal(browser_);

[Peter Kasting, 2014/12/12 01:20:56]

This change isn't appropriate for a generic base class of several different
icons.  Not all icons trigger bookmarking, only the star does.

You should be implementing this behavior in the star subclass, not here.

This also means the base class has no reason to be provided with the Browser
object, and subclasses other than the star don't need it either.

 }