Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3791)

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.h

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/bubble_icon_view.h
diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.h b/chrome/browser/ui/views/location_bar/bubble_icon_view.h
index 764282435af0e641d427602d8369561d12fede12..4be1893f8889658d8bee1709dc9a7bf4a4d44c03 100644
--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.h
+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.h
@@ -7,6 +7,7 @@
#include "ui/views/controls/image_view.h"
+class Browser;
class CommandUpdater;
// Represents an icon on the omnibox that shows a bubble when clicked.
@@ -18,7 +19,9 @@ class BubbleIconView : public views::ImageView {
EXECUTE_SOURCE_GESTURE,
};
- explicit BubbleIconView(CommandUpdater* command_updater, int command_id);
+ explicit BubbleIconView(CommandUpdater* command_updater,
+ int command_id,
+ Browser* browser);
Peter Kasting 2014/12/12 01:20:57 Nit: While here: This shouldn't be explicit as it'
Deepak 2014/12/12 06:49:47 Done.
~BubbleIconView() override;
// Returns true if a related bubble is showing.
@@ -48,6 +51,9 @@ class BubbleIconView : public views::ImageView {
// The command ID executed when the user clicks this icon.
const int command_id_;
+ // The Browser for bookmarking by selecting star icon.
+ Browser* browser_;
+
// This is used to check if the bookmark bubble was showing during the mouse
// pressed event. If this is true then the mouse released event is ignored to
// prevent the bubble from reshowing.

Powered by Google App Engine
This is Rietveld 408576698