Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

chrome/browser/ui/views/location_bar/bubble_icon_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/bubble_icon_view.h"
 
 #include "chrome/browser/command_updater.h"
+#include "chrome/browser/ui/browser_commands.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/events/event.h"
 
-BubbleIconView::BubbleIconView(CommandUpdater* command_updater, int command_id)
+BubbleIconView::BubbleIconView(CommandUpdater* command_updater,
+                               int command_id,
+                               Browser* browser)
     : command_updater_(command_updater),
       command_id_(command_id),
+      browser_(browser),
       suppress_mouse_released_action_(false) {
   SetAccessibilityFocusable(true);
 }
 
 BubbleIconView::~BubbleIconView() {
 }
 
 void BubbleIconView::GetAccessibleState(ui::AXViewState* state) {
   views::ImageView::GetAccessibleState(state);
   state->role = ui::AX_ROLE_BUTTON;
@@ skipping 40 matching lines @@
 
 void BubbleIconView::OnGestureEvent(ui::GestureEvent* event) {
   if (event->type() == ui::ET_GESTURE_TAP) {
     ExecuteCommand(EXECUTE_SOURCE_GESTURE);
     event->SetHandled();
   }
 }
 
 void BubbleIconView::ExecuteCommand(ExecuteSource source) {
   OnExecuting(source);
-  if (command_updater_)
-    command_updater_->ExecuteCommand(command_id_);
+  if (browser_)
+    chrome::BookmarkCurrentPageInternal(browser_);

[Peter Kasting, 2014/12/12 01:20:56]

This change isn't appropriate for a generic base class of several different
icons.  Not all icons trigger bookmarking, only the star does.

You should be implementing this behavior in the star subclass, not here.

This also means the base class has no reason to be provided with the Browser
object, and subclasses other than the star don't need it either.

 }