chrome/browser/ui/views/location_bar/location_bar_view.cc - Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/location_bar/bubble_icon_view.cc ('K') | « chrome/browser/ui/views/location_bar/bubble_icon_view.cc ('k') | chrome/browser/ui/views/location_bar/star_view.h » ('j') | chrome/browser/ui/views/location_bar/star_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc

index 1679bda77264e3cd3d150523c167e8712ebed3ae..758181cbbde68a289b0f2ed6487c444754aec433 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc

@@ -327,14 +327,15 @@ void LocationBarView::Init() {

open_pdf_in_reader_view_ = new OpenPDFInReaderView();

AddChildView(open_pdf_in_reader_view_);

- manage_passwords_icon_view_ = new ManagePasswordsIconView(command_updater());

+ manage_passwords_icon_view_ =

+ new ManagePasswordsIconView(command_updater(), 0);

AddChildView(manage_passwords_icon_view_);

- translate_icon_view_ = new TranslateIconView(command_updater());

+ translate_icon_view_ = new TranslateIconView(command_updater(), 0);

translate_icon_view_->SetVisible(false);

AddChildView(translate_icon_view_);

- star_view_ = new StarView(command_updater());

+ star_view_ = new StarView(command_updater(), browser_);

star_view_->SetVisible(false);

AddChildView(star_view_);