Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 764763005: Plugin Power Saver: Always mark 'tiny' plugins as essential. (Closed)

Created:
6 years ago by tommycli
Modified:
6 years ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@0201-plugin-power-saver-use-poster-frame-on-blocked-only
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Always mark 'tiny' plugins as essential. Tiny plugins often serve a vital purpose on a page, and cannot be effectively clicked by a user. Therefore are always marked as essential. BUG=403800 Committed: https://crrev.com/94f90ec84580a0abebdb44184cbcd60f8e1d62ca Cr-Commit-Position: refs/heads/master@{#306751}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : format #

Patch Set 4 : #

Total comments: 11

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -42 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_throttler.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper_browsertest.cc View 1 2 3 2 chunks +35 lines, -22 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper_impl.h View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper_impl.cc View 1 2 3 4 6 chunks +26 lines, -13 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
tommycli
groby: let me know if this does the trick for you
6 years ago (2014-12-02 18:01:24 UTC) #2
groby-ooo-7-16
I don't think small plugins should trigger the cross-origin whitelisting. (For the obvious reason that ...
6 years ago (2014-12-02 18:10:45 UTC) #3
tommycli
groby: you are correct. See if this new version looks better.
6 years ago (2014-12-02 18:32:12 UTC) #4
groby-ooo-7-16
https://codereview.chromium.org/764763005/diff/60001/content/renderer/pepper/plugin_power_saver_helper_browsertest.cc File content/renderer/pepper/plugin_power_saver_helper_browsertest.cc (right): https://codereview.chromium.org/764763005/diff/60001/content/renderer/pepper/plugin_power_saver_helper_browsertest.cc#newcode9 content/renderer/pepper/plugin_power_saver_helper_browsertest.cc:9: #include "content/renderer/pepper/plugin_power_saver_helper_impl.h" I know it's not directly relevant to ...
6 years ago (2014-12-03 00:57:27 UTC) #5
tommycli
groby: Addressed your comments. Wasn't able to make all the changes you requested. See below. ...
6 years ago (2014-12-03 19:34:13 UTC) #6
tommycli
dmichael: May I have a content/renderer/pepper review? isherman: May I have a tools/ review? Thanks!
6 years ago (2014-12-03 19:38:07 UTC) #8
Ilya Sherman
histograms.xml lgtm
6 years ago (2014-12-03 19:38:39 UTC) #9
dmichael (off chromium)
pepper lgtm when it lgtgroby
6 years ago (2014-12-03 20:33:46 UTC) #10
tommycli
dmichael, isherman: thanks guys. Yes I will wait on groby to take a look before ...
6 years ago (2014-12-03 20:39:26 UTC) #11
groby-ooo-7-16
lgtm https://codereview.chromium.org/764763005/diff/60001/content/renderer/pepper/plugin_power_saver_helper_browsertest.cc File content/renderer/pepper/plugin_power_saver_helper_browsertest.cc (right): https://codereview.chromium.org/764763005/diff/60001/content/renderer/pepper/plugin_power_saver_helper_browsertest.cc#newcode9 content/renderer/pepper/plugin_power_saver_helper_browsertest.cc:9: #include "content/renderer/pepper/plugin_power_saver_helper_impl.h" On 2014/12/03 19:34:12, tommycli wrote: > ...
6 years ago (2014-12-04 02:42:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764763005/80001
6 years ago (2014-12-04 02:43:27 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years ago (2014-12-04 02:45:41 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-04 02:46:30 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/94f90ec84580a0abebdb44184cbcd60f8e1d62ca
Cr-Commit-Position: refs/heads/master@{#306751}

Powered by Google App Engine
This is Rietveld 408576698