Plugin Power Saver: Always mark 'tiny' plugins as essential.

content/renderer/pepper/plugin_power_saver_helper_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_PEPPER_PLUGIN_POWER_SAVER_HELPER_IMPL_H_
 #define CONTENT_RENDERER_PEPPER_PLUGIN_POWER_SAVER_HELPER_IMPL_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 14 matching lines @@
   // PluginPluginPowerSaverHelper implementation.
   GURL GetPluginInstancePosterImage(const blink::WebPluginParams& params,
                                     const GURL& base_url) const override;
   void RegisterPeripheralPlugin(
       const GURL& content_origin,
       const base::Closure& unthrottle_callback) override;
 
   // Returns true if this plugin should have power saver enabled.
   //
   // Power Saver is enabled for plugin content that are cross-origin and
-  // heuristically determined to be not the "main attraction" of the webpage.
+  // heuristically determined to be not essential to the web page content.
   //
   // Plugin content is defined to be cross-origin when the plugin source's
   // origin differs from the top level frame's origin. For example:
   //  - Cross-origin:  a.com -> b.com/plugin.swf
   //  - Cross-origin:  a.com -> b.com/iframe.html -> b.com/plugin.swf
   //  - Same-origin:   a.com -> b.com/iframe-to-a.html -> a.com/plugin.swf
   //
-  // |cross_origin| may not be NULL.
+  // |is_main_attraction| may be NULL. It is set to true if the plugin content
+  // is cross-origin and determined to be the "main attraction" of the page.

[groby-ooo-7-16, 2014/12/03 00:57:27]

Is there a reason why we can't handle the whitelisting inside of PPSH? Does
anybody care about |is_main_attraction|, except to handle whitelisting?

[tommycli, 2014/12/03 19:34:12]

Originally it handled the whitelisting within this function. I pulled that out
because thestig recommended this method be 'const' and we have a separate
whitelisting function.

[groby-ooo-7-16, 2014/12/04 02:42:58]

Let's take this out of this CL, but I don't like that we have split
responsibilities for whitelisting. (Plus, "tell don't ask" applies for state
queries)

   virtual bool ShouldThrottleContent(const GURL& content_origin,
                                      int width,
                                      int height,
-                                     bool* cross_origin) const;
+                                     bool* is_main_attraction) const;

[groby-ooo-7-16, 2014/12/03 00:57:27]

You should probably rename it in plugin_power_saver_helper.h as well.  In fact,
since that's the public API, you'd probably do well to just move all the
comments there, and remove comments here. (Otherwise you'll always maintain two
sets of comments)

[tommycli, 2014/12/03 19:34:12]

This doesn't exist in the public interface due to content/ owners requesting a
minimum number of exposed functions.

[groby-ooo-7-16, 2014/12/04 02:42:58]

Ah - I'm still operating on outdated codesearch results ;) So yes, no need to
rename.

 
   virtual void WhitelistContentOrigin(const GURL& content_origin);
 
  private:
   struct PeripheralPlugin {
     PeripheralPlugin(const GURL& content_origin,
                      const base::Closure& unthrottle_callback);
     ~PeripheralPlugin();
 
     GURL content_origin;
@@ skipping 12 matching lines @@
 
   // Set of peripheral plugins eligible to be unthrottled ex post facto.
   std::vector<PeripheralPlugin> peripheral_plugins_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginPowerSaverHelperImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_PEPPER_PLUGIN_POWER_SAVER_HELPER_IMPL_H_