Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1881)

Unified Diff: content/renderer/pepper/plugin_power_saver_helper_impl.h

Issue 764763005: Plugin Power Saver: Always mark 'tiny' plugins as essential. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0201-plugin-power-saver-use-poster-frame-on-blocked-only
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/plugin_power_saver_helper_impl.h
diff --git a/content/renderer/pepper/plugin_power_saver_helper_impl.h b/content/renderer/pepper/plugin_power_saver_helper_impl.h
index 55546fdc218fe59fc287b661c67fc436fa64d451..68bf197af475e4cc725911cc325fd03d87916021 100644
--- a/content/renderer/pepper/plugin_power_saver_helper_impl.h
+++ b/content/renderer/pepper/plugin_power_saver_helper_impl.h
@@ -32,7 +32,7 @@ class CONTENT_EXPORT PluginPowerSaverHelperImpl : public PluginPowerSaverHelper,
// Returns true if this plugin should have power saver enabled.
//
// Power Saver is enabled for plugin content that are cross-origin and
- // heuristically determined to be not the "main attraction" of the webpage.
+ // heuristically determined to be not essential to the web page content.
//
// Plugin content is defined to be cross-origin when the plugin source's
// origin differs from the top level frame's origin. For example:
@@ -40,13 +40,14 @@ class CONTENT_EXPORT PluginPowerSaverHelperImpl : public PluginPowerSaverHelper,
// - Cross-origin: a.com -> b.com/iframe.html -> b.com/plugin.swf
// - Same-origin: a.com -> b.com/iframe-to-a.html -> a.com/plugin.swf
//
- // |cross_origin| may not be NULL.
+ // |is_main_attraction| may be NULL. It is set to true if the plugin content
+ // is cross-origin and determined to be the "main attraction" of the page.
//
// Virtual to allow overriding in tests.
virtual bool ShouldThrottleContent(const GURL& content_origin,
int width,
int height,
- bool* cross_origin) const;
+ bool* is_main_attraction) const;
// Virtual to allow overriding in tests.
virtual void WhitelistContentOrigin(const GURL& content_origin);

Powered by Google App Engine
This is Rietveld 408576698