Plugin Power Saver: Always mark 'tiny' plugins as essential.

content/renderer/pepper/plugin_power_saver_helper_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "content/common/frame_messages.h"
 #include "content/common/view_message_enums.h"
 #include "content/public/test/render_view_test.h"
 #include "content/renderer/pepper/plugin_power_saver_helper_impl.h"

[groby-ooo-7-16, 2014/12/03 00:57:27]

I know it's not directly relevant to this CL, but: Do you ever need the Impl
class here? Shouldn't this test against the base class interface?

[tommycli, 2014/12/03 19:34:12]

I cannot, as the content/ owners requested that I pull ShouldThrottleContent and
WhitelistContentOrigin outside of the content-public interface.

[groby-ooo-7-16, 2014/12/04 02:42:58]

Grumble mumble. Fine. At some point we'll need to find a single home for this,
either chrome/ or content/. The boundary skipping seems to overcomplicate
things. (But that's neither here nor there for the CL, so ignore)

 #include "content/renderer/render_frame_impl.h"
 #include "content/renderer/render_view_impl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebPluginParams.h"
 #include "url/gurl.h"
 
 namespace content {
 
@@ skipping 49 matching lines @@
 
   // Ignore poster parameter when plugin is big (shouldn't be throttled).
   params.attributeValues[0] = "poster.jpg";
   params.attributeValues[1] = "500";
   params.attributeValues[2] = "500";
   EXPECT_EQ(GURL(), power_saver_helper()->GetPluginInstancePosterImage(
                         params, GURL("http://a.com/page.html")));
 }
 
 TEST_F(PluginPowerSaverHelperTest, AllowSameOrigin) {
-  bool cross_origin = false;
-  EXPECT_FALSE(power_saver_helper()->ShouldThrottleContent(
-      GURL(), 100, 100, &cross_origin));
-  EXPECT_FALSE(cross_origin);
+  EXPECT_FALSE(
+      power_saver_helper()->ShouldThrottleContent(GURL(), 100, 100, nullptr));
 
-  EXPECT_FALSE(power_saver_helper()->ShouldThrottleContent(
-      GURL(), 1000, 1000, &cross_origin));
-  EXPECT_FALSE(cross_origin);
+  EXPECT_FALSE(
+      power_saver_helper()->ShouldThrottleContent(GURL(), 1000, 1000, nullptr));
 }
 
 TEST_F(PluginPowerSaverHelperTest, DisallowCrossOriginUnlessLarge) {
-  bool cross_origin = false;
+  bool is_main_attraction = false;
   EXPECT_TRUE(power_saver_helper()->ShouldThrottleContent(
-      GURL("http://other.com"), 100, 100, &cross_origin));
-  EXPECT_TRUE(cross_origin);
+      GURL("http://other.com"), 100, 100, &is_main_attraction));
+  EXPECT_FALSE(is_main_attraction);
 
   EXPECT_FALSE(power_saver_helper()->ShouldThrottleContent(
-      GURL("http://other.com"), 1000, 1000, &cross_origin));
-  EXPECT_TRUE(cross_origin);
+      GURL("http://other.com"), 1000, 1000, &is_main_attraction));
+  EXPECT_TRUE(is_main_attraction);
+}
+
+TEST_F(PluginPowerSaverHelperTest, AlwaysAllowTinyContent) {
+  bool is_main_attraction = false;
+  EXPECT_FALSE(power_saver_helper()->ShouldThrottleContent(
+      GURL(), 1, 1, &is_main_attraction));
+  EXPECT_FALSE(is_main_attraction);
+
+  EXPECT_FALSE(power_saver_helper()->ShouldThrottleContent(
+      GURL("http://other.com"), 1, 1, &is_main_attraction));
+  EXPECT_FALSE(is_main_attraction);
+
+  EXPECT_FALSE(power_saver_helper()->ShouldThrottleContent(
+      GURL("http://other.com"), 5, 5, &is_main_attraction));
+  EXPECT_FALSE(is_main_attraction);
+
+  EXPECT_TRUE(power_saver_helper()->ShouldThrottleContent(
+      GURL("http://other.com"), 10, 10, &is_main_attraction));
+  EXPECT_FALSE(is_main_attraction);
 }
 
 TEST_F(PluginPowerSaverHelperTest, TemporaryOriginWhitelist) {
-  bool cross_origin = false;
+  bool is_main_attraction = false;
   EXPECT_TRUE(power_saver_helper()->ShouldThrottleContent(
-      GURL("http://other.com"), 100, 100, &cross_origin));
-  EXPECT_TRUE(cross_origin);
+      GURL("http://other.com"), 100, 100, &is_main_attraction));
+  EXPECT_FALSE(is_main_attraction);
 
   // Clear out other messages so we find just the plugin power saver IPCs.
   sink_->ClearMessages();
 
   power_saver_helper()->WhitelistContentOrigin(GURL("http://other.com"));
   EXPECT_FALSE(power_saver_helper()->ShouldThrottleContent(
-      GURL("http://other.com"), 100, 100, &cross_origin));
-  EXPECT_TRUE(cross_origin);
+      GURL("http://other.com"), 100, 100, &is_main_attraction));
+  EXPECT_FALSE(is_main_attraction);
 
   // Test that we've sent an IPC to the browser.
   ASSERT_EQ(1u, sink_->message_count());
   const IPC::Message* msg = sink_->GetMessageAt(0);
   EXPECT_EQ(FrameHostMsg_PluginContentOriginAllowed::ID, msg->type());
   FrameHostMsg_PluginContentOriginAllowed::Param params;
   FrameHostMsg_PluginContentOriginAllowed::Read(msg, &params);
   EXPECT_EQ(GURL("http://other.com"), params.a);
 }
 
 TEST_F(PluginPowerSaverHelperTest, UnthrottleOnExPostFactoWhitelist) {
   base::RunLoop loop;
   power_saver_helper()->RegisterPeripheralPlugin(GURL("http://other.com"),
                                                  loop.QuitClosure());
 
   std::set<GURL> origin_whitelist;
   origin_whitelist.insert(GURL("http://other.com"));
   frame()->OnMessageReceived(FrameMsg_UpdatePluginContentOriginWhitelist(
       frame()->GetRoutingID(), origin_whitelist));
 
   // Runs until the unthrottle closure is run.
   loop.Run();
 }
 
 TEST_F(PluginPowerSaverHelperTest, ClearWhitelistOnNavigate) {
   power_saver_helper()->WhitelistContentOrigin(GURL("http://other.com"));
 
-  bool cross_origin = false;
   EXPECT_FALSE(power_saver_helper()->ShouldThrottleContent(
-      GURL("http://other.com"), 100, 100, &cross_origin));
-  EXPECT_TRUE(cross_origin);
+      GURL("http://other.com"), 100, 100, nullptr));
 
   LoadHTML("<html></html>");
 
   EXPECT_TRUE(power_saver_helper()->ShouldThrottleContent(
-      GURL("http://other.com"), 100, 100, &cross_origin));
-  EXPECT_TRUE(cross_origin);
+      GURL("http://other.com"), 100, 100, nullptr));
 }
 
 }  // namespace content