Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 757233003: Do not provisionally send ImeCompositionRangeChanged IPC on Android (Closed)

Created:
6 years ago by yukawa
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not provisionally send ImeCompositionRangeChanged message on Android This CL effectively disables r301384, that provisionally plumbed ImeCompositionRangeChanged from the renderer to the browser. However, the character bounds is not actually used yet in the browser process. Hence we shouldn't have turned this on until everything becomes ready. BUG=424866 TEST=Manually made sure that the browser process doesn't receive the event. Committed: https://crrev.com/6f899b27049b077e88582c0b73861d1db63e4512 Cr-Commit-Position: refs/heads/master@{#308381}

Patch Set 1 #

Patch Set 2 : Remove unnecessary include #

Patch Set 3 : Rebase on top of https://codereview.chromium.org/780343002 #

Total comments: 2

Patch Set 4 : Address comment from jdduke #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M content/renderer/render_widget.cc View 1 2 3 3 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
yukawa
6 years ago (2014-12-05 05:27:58 UTC) #2
jdduke (slow)
On 2014/12/05 05:27:58, yukawa wrote: Thanks, this is probably fine, though you might also consider ...
6 years ago (2014-12-05 06:16:50 UTC) #3
yukawa
On 2014/12/05 06:16:50, jdduke wrote: > On 2014/12/05 05:27:58, yukawa wrote: > > Thanks, this ...
6 years ago (2014-12-05 07:37:52 UTC) #4
jdduke (slow)
On 2014/12/05 07:37:52, yukawa wrote: > On 2014/12/05 06:16:50, jdduke wrote: > > On 2014/12/05 ...
6 years ago (2014-12-05 16:09:54 UTC) #5
yukawa
On 2014/12/05 16:09:54, jdduke wrote: > On 2014/12/05 07:37:52, yukawa wrote: > > On 2014/12/05 ...
6 years ago (2014-12-12 17:40:32 UTC) #6
jdduke (slow)
Yeah, this seems reasonable, you'll just need an owner. https://codereview.chromium.org/757233003/diff/40001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/757233003/diff/40001/content/renderer/render_widget.cc#newcode2020 content/renderer/render_widget.cc:2020: ...
6 years ago (2014-12-12 17:43:45 UTC) #7
yukawa
Adding jochen@ for OWNER review. Jochen, can you take a look as an OWNER? The ...
6 years ago (2014-12-12 18:11:35 UTC) #9
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-15 15:35:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757233003/60001
6 years ago (2014-12-15 16:10:55 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-15 18:56:19 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-15 18:58:15 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6f899b27049b077e88582c0b73861d1db63e4512
Cr-Commit-Position: refs/heads/master@{#308381}

Powered by Google App Engine
This is Rietveld 408576698