Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 784503002: Revert "Plumb composition character bounds from C++ to Java" (Closed)

Created:
6 years ago by yukawa
Modified:
6 years ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Plumb composition character bounds from C++ to Java" This reverts commit 6d6a279a1cf7d9e8b5072740a494c4031eaa133d. Turned out that this CL is not necessary. BUG=424866 TBR=aelias@chromium.org Committed: https://crrev.com/cf1b16837d5482473d390a23e664ceaeba78421a Cr-Commit-Position: refs/heads/master@{#308038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -41 lines) Patch
M content/browser/renderer_host/ime_adapter_android.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
yukawa
Hi Alexandre, Aurimas. Can you take a look? Reverting this CL also makes it easy ...
6 years ago (2014-12-05 07:35:34 UTC) #2
jdduke (slow)
On 2014/12/05 07:35:34, yukawa wrote: > Hi Alexandre, Aurimas. Can you take a look? > ...
6 years ago (2014-12-05 16:07:52 UTC) #3
yukawa
On 2014/12/05 16:07:52, jdduke wrote: > On 2014/12/05 07:35:34, yukawa wrote: > > Hi Alexandre, ...
6 years ago (2014-12-05 23:18:46 UTC) #4
jdduke (slow)
On 2014/12/05 23:18:46, yukawa wrote: > On 2014/12/05 16:07:52, jdduke wrote: > > On 2014/12/05 ...
6 years ago (2014-12-05 23:20:08 UTC) #5
jdduke (slow)
As a straightforward revert that has no user-facing effect, feel free to TBR owners if ...
6 years ago (2014-12-12 01:02:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/784503002/1
6 years ago (2014-12-12 01:06:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 02:52:46 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-12 02:54:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf1b16837d5482473d390a23e664ceaeba78421a
Cr-Commit-Position: refs/heads/master@{#308038}

Powered by Google App Engine
This is Rietveld 408576698