Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2779)

Unified Diff: content/renderer/render_widget.cc

Issue 757233003: Do not provisionally send ImeCompositionRangeChanged IPC on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment from jdduke Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 537694ea95cf7573da4334b78af6a6b0059e8990..950881052a2f50d995422797c29c275ff6af8c2b 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -77,7 +77,6 @@
#if defined(OS_ANDROID)
#include <android/keycodes.h>
-#include "base/android/build_info.h"
#include "content/renderer/android/synchronous_compositor_factory.h"
#endif
@@ -2017,12 +2016,9 @@ ui::TextInputType RenderWidget::GetTextInputType() {
void RenderWidget::UpdateCompositionInfo(bool should_update_range) {
#if defined(OS_ANDROID)
- // Sending composition info makes sense only in Lollipop (API level 21)
- // and above due to the API availability.
- if (base::android::BuildInfo::GetInstance()->sdk_int() < 21)
- return;
-#endif
-
+ // TODO(yukawa): Start sending character bounds when the browser side
+ // implementation becomes ready (crbug.com/424866).
+#else
gfx::Range range = gfx::Range();
if (should_update_range) {
GetCompositionRange(&range);
@@ -2038,6 +2034,7 @@ void RenderWidget::UpdateCompositionInfo(bool should_update_range) {
composition_range_ = range;
Send(new InputHostMsg_ImeCompositionRangeChanged(
routing_id(), composition_range_, composition_character_bounds_));
+#endif
}
void RenderWidget::GetCompositionCharacterBounds(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698