[Telemetry] Stop execution for unexpected exceptions

Stop execution for unexpected exceptions like KeyboardInterrupt...
We "white list" some exceptions which user story runner can continue running
the rest of user stories even if they are raised during the test run.

Those exceptions are:
page_test.Failure
util.TimeoutException
exceptions.LoginException
exceptions.ProfilingException
page_action.PageActionNotSupported
exceptions.AppCrashException (except if this is thrown inside
shared_user_story_state.state.TearDownState(), which indicates a failure of
recovering the test state)

BUG=437735
Committed: https://crrev.com/68084e84746b6eebd9103be0f441c4e6441fbd15
Cr-Commit-Position: refs/heads/master@{#308258}

[slamm, 2014-12-02 00:27:51]

Is it possible to return None from StopTracing?

[slamm, 2014-12-02 00:39:19]

Return TracingTimelineData without events

[nednguyen, 2014-12-02 01:45:33]

On 2014/12/02 00:39:19, slamm wrote:
> Return TracingTimelineData without events

It seems to me that the code in shared_page_state.DidRunUserStory should do the
check instead.

[slamm, 2014-12-03 23:45:46]

Handle multiple exceptions

[slamm, 2014-12-04 00:05:00]

another iteration

[nednguyen, 2014-12-04 04:51:24]

nednguyen@google.com changed reviewers:
+ chrishenry@google.com

[nednguyen, 2014-12-04 05:05:08]

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
(right):

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py:313:
return tracing_timeline_data.TracingTimelineData(event_data)
Can you drop this change? If browser is not running, calling StopTracing should
raise error to make debugging easier.
Fail earlier is usually better.

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/shared_user_story_state.py (right):

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/shared_user_story_state.py:25:
self._is_early_tear_down_requested = True
I would want us to avoid adding this since shared_user_story_state is state
shared by many user stories and each one has handle to shared_user_story_state.

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_runner.py (left):

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_runner.py:105:
state.TearDownState(results)
Sorry for this ugly hack :-(. Removing the TearDownState() call here is the
right direction, but I don't think we need the RequestEarlyTearDown().

How about reraise the AppCrashException here and catch AppCrashException in
Run() and call tearDownState there.

[slamm, 2014-12-04 17:38:44]

Handle AppGoneException without additional member in shared_user_story_state.

[slamm, 2014-12-04 17:48:01]

Tweak style.

[slamm, 2014-12-04 17:57:45]

I could write a context manager to handle the extra try-except blocks. However,
I am unsure if it is worth the effort and I want to make sure we agree on this
approach.

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
(right):

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py:313:
return tracing_timeline_data.TracingTimelineData(event_data)
On 2014/12/04 05:05:07, nednguyen wrote:
> Can you drop this change? If browser is not running, calling StopTracing
should
> raise error to make debugging easier.
> Fail earlier is usually better.

Done. 

Although, what I wanted to do was avoid getting an error if we already know it
will fail.

Without this, you see an extra stack track (not really helpful) when you ctrl-C
in the middle of a run:


[ RUN      ] http://games.yahoo.com
^C
Exception from DidRunUserStory:

Traceback (most recent call last):
  _RunUserStoryAndProcessErrorIfNeeded at
tools/telemetry/telemetry/user_story/user_story_runner.py:117
    state.DidRunUserStory(results)
  DidRunUserStory at tools/telemetry/telemetry/page/shared_page_state.py:73
    self._test.CleanUpAfterPage(self._current_page, self._current_tab)
  CleanUpAfterPage at tools/perf/measurements/smoothness.py:46
    self._smoothness_controller.CleanUp(tab)
  CleanUp at tools/perf/measurements/smoothness_controller.py:130
    tab.browser.platform.tracing_controller.Stop()
  Stop at tools/telemetry/telemetry/core/platform/tracing_controller.py:32
    return self._tracing_controller_backend.Stop()
  Stop at
tools/telemetry/telemetry/core/platform/tracing_controller_backend.py:41
    result = browser_backend.StopTracing()
  StopTracing at
tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py:318
    "console.time.toString().indexOf('[native code]') != -1;")
  EvaluateJavaScript at tools/telemetry/telemetry/core/web_contents.py:117
    expr, context_id=None, timeout=timeout)
  EvaluateJavaScriptInContext at
tools/telemetry/telemetry/core/web_contents.py:133
    expr, context_id=context_id, timeout=timeout)
  EvaluateJavaScript at
tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py:171
    return self._runtime.Evaluate(expr, context_id, timeout)
  Evaluate at
tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py:40
    res = self._inspector_backend.SyncRequest(request, timeout)
  SyncRequest at
tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py:112
    res = self._Receive(timeout)
  _Receive at
tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py:173
    self._error_handler(elapsed_time)
  _HandleError at
tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py:235
    'longer exists, assuming it crashed. Error=%s' % sys.exc_info()[1])
DevtoolsTargetCrashException: Received a socket error in the browser connection
and the tab no longer exists, assuming it crashed. Error=
Stack Trace:
********************************************************************************
        No crash dump found. Returning browser stdout:
        nssecurity:DynamicRegistrationFunction(): Netscape Security Wrapper
Initialized 0.99.15 $DateTime: 2012/02/20 07:36:10 $
       
[WARNING:/Volumes/Builds/jenkins/ws/St_Make/code/products/player/pepper/gypbuild/../../../../flash/platform/pepper/pep_viewclient.cpp(357)]
Could not create display context.
       
[WARNING:/Volumes/Builds/jenkins/ws/St_Make/code/products/player/pepper/gypbuild/../../../../flash/platform/pepper/pep_viewclient.cpp(357)]
Could not create display context.

********************************************************************************

Locals:
  elapsed_time : 2.9087066650390625e-05

[       OK ] http://games.yahoo.com (4627 ms)

Traceback (most recent call last):
  <module> at tools/perf/run_benchmark:18
    sys.exit(benchmark_runner.main())
  main at tools/telemetry/telemetry/benchmark_runner.py:345
    return command().Run(options)
  Run at tools/telemetry/telemetry/benchmark_runner.py:162
    return min(255, self._benchmark().Run(args))
  Run at tools/telemetry/telemetry/benchmark.py:105
    user_story_runner.Run(pt, us, expectations, finder_options, results)
  Run at tools/telemetry/telemetry/user_story/user_story_runner.py:244
    test, expectations, user_story, results, state)
  _RunUserStoryAndProcessErrorIfNeeded at
tools/telemetry/telemetry/user_story/user_story_runner.py:96
    state.RunUserStory(results)
  RunUserStory at tools/telemetry/telemetry/page/shared_page_state.py:228
    self._ImplicitPageNavigation()
  _ImplicitPageNavigation at
tools/telemetry/telemetry/page/shared_page_state.py:223
    self._test.RunNavigateSteps(self._current_page, self._current_tab)
  RunNavigateSteps at tools/telemetry/telemetry/page/page_test.py:273
    page.RunNavigateSteps(action_runner)
  RunNavigateSteps at tools/perf/page_sets/top_pages.py:259
    action_runner.Wait(2)
  Wait at tools/telemetry/telemetry/page/actions/action_runner.py:158
    time.sleep(seconds)
KeyboardInterrupt

Locals:
  seconds : 2

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/shared_user_story_state.py (right):

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/shared_user_story_state.py:25:
self._is_early_tear_down_requested = True
On 2014/12/04 05:05:07, nednguyen wrote:
> I would want us to avoid adding this since shared_user_story_state is state
> shared by many user stories and each one has handle to
shared_user_story_state.

Done.

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_runner.py (left):

https://codereview.chromium.org/755323012/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_runner.py:105:
state.TearDownState(results)
On 2014/12/04 05:05:07, nednguyen wrote:
> Sorry for this ugly hack :-(. Removing the TearDownState() call here is the
> right direction, but I don't think we need the RequestEarlyTearDown().
> 
> How about reraise the AppCrashException here and catch AppCrashException in
> Run() and call tearDownState there.

Done.

[slamm, 2014-12-04 18:43:37]

Rebase

[chrishenry, 2014-12-05 01:47:23]

On 2014/12/04 17:57:45, slamm wrote:
> I could write a context manager to handle the extra try-except blocks.
However,
> I am unsure if it is worth the effort and I want to make sure we agree on this
> approach.
> 

As discussed earlier, let's use a lightweight best effort approach (of
try-catch-ing and reporting benchmark-level failure or user story failure where
appropriate) for now. We might go for something more frameworky in the future
but it doesn't seem worth the effort right now (and we already have tons of
other work queued up).

[chrishenry, 2014-12-05 01:57:02]

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (left):

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:89: 
nit: Please re-add this blank line.

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:99: raise
Why is this deleted? This is being catch in Benchmark. I suspect this change may
be right if TestExpectation also handles platform mismatch failure.

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (right):

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:248: state = None
Curious, why bother with the temp_state dance? Can't you just do:

try:
  state.TearDownState(results)
except ...:
  if ...:
    raise  # don't care about state anymore!
  ...
# if we continue, reset the state!
state = group.shared_user_story_state_class

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:259:
has_existing_exception = sys.exc_info() is not None
Can we have unit test for all of these changes, if possible?

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:288: msg='Exception
from TearDownState:')
This logic and the logic above is the same, maybe extract a method called, say,
TearDownStateSafely(state)?

[slamm, 2014-12-12 00:48:49]

Ned asked me to make this a priority (over PageTest use in user_story_runner).

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (left):

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:89: 
On 2014/12/05 01:57:02, chrishenry wrote:
> nit: Please re-add this blank line.

Done.

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:99: raise
On 2014/12/05 01:57:02, chrishenry wrote:
> Why is this deleted? This is being catch in Benchmark. I suspect this change
may
> be right if TestExpectation also handles platform mismatch failure.

This does not do anything useful. It catches it and them immediately raises it
again.

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (right):

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:248: state = None
On 2014/12/05 01:57:02, chrishenry wrote:
> Curious, why bother with the temp_state dance? Can't you just do:
> 
> try:
>   state.TearDownState(results)
> except ...:
>   if ...:
>     raise  # don't care about state anymore!
>   ...
> # if we continue, reset the state!
> state = group.shared_user_story_state_class

I changed it to always print TearDownState exceptions and re-raise the
AppCrashException.
That makes it a requirement to tear down cleanly after an app crash.
(If you would rather have the policy be to not raise either, that would be easy
too.)

I added a finally-block to set state to None.

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:259:
has_existing_exception = sys.exc_info() is not None
On 2014/12/05 01:57:02, chrishenry wrote:
> Can we have unit test for all of these changes, if possible?

I added test coverage.

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:288: msg='Exception
from TearDownState:')
On 2014/12/05 01:57:02, chrishenry wrote:
> This logic and the logic above is the same, maybe extract a method called,
say,
> TearDownStateSafely(state)?

Done.

[chrishenry, 2014-12-12 00:59:25]

lgtm, but please wait for Ned.

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (left):

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:99: raise
On 2014/12/12 00:48:49, slamm wrote:
> On 2014/12/05 01:57:02, chrishenry wrote:
> > Why is this deleted? This is being catch in Benchmark. I suspect this change
> may
> > be right if TestExpectation also handles platform mismatch failure.
> 
> This does not do anything useful. It catches it and them immediately raises it
> again.

It is useful, because it is a subclass of page_test.Failure. Add a comment after
you restore this.

https://codereview.chromium.org/755323012/diff/140001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (right):

https://codereview.chromium.org/755323012/diff/140001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:256: raise
app_crash_exception  # require clean tear down
Can you make the comment clearer? What exactly does it mean by "clean tear
down"?

[nednguyen, 2014-12-12 03:03:24]

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (left):

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:99: raise
On 2014/12/12 00:59:25, chrishenry wrote:
> On 2014/12/12 00:48:49, slamm wrote:
> > On 2014/12/05 01:57:02, chrishenry wrote:
> > > Why is this deleted? This is being catch in Benchmark. I suspect this
change
> > may
> > > be right if TestExpectation also handles platform mismatch failure.
> > 
> > This does not do anything useful. It catches it and them immediately raises
it
> > again.
> 
> It is useful, because it is a subclass of page_test.Failure. Add a comment
after
> you restore this.

Then the solution sounds like it should not be a subclass of page_test.Failure

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (right):

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:288: msg='Exception
from TearDownState:')
On 2014/12/12 00:48:49, slamm wrote:
> On 2014/12/05 01:57:02, chrishenry wrote:
> > This logic and the logic above is the same, maybe extract a method called,
> say,
> > TearDownStateSafely(state)?
> 
> Done.

ping?

[nednguyen, 2014-12-12 03:04:05]

LGTM with nits

[nednguyen, 2014-12-12 03:13:26]

On 2014/12/12 03:04:05, nednguyen wrote:
> LGTM with nits

I also updated the description a little bit to reflect your change. Can we have
documentation in the code somewhere that explains this exception handling
strategy?

[slamm, 2014-12-12 18:40:56]

Review comments

[slamm, 2014-12-12 18:47:33]

comment tweaks

[slamm, 2014-12-12 18:58:34]

Another comment tweak

[slamm, 2014-12-12 19:00:08]

Ready to go.

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (left):

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:99: raise
On 2014/12/12 03:03:23, nednguyen wrote:
> On 2014/12/12 00:59:25, chrishenry wrote:
> > On 2014/12/12 00:48:49, slamm wrote:
> > > On 2014/12/05 01:57:02, chrishenry wrote:
> > > > Why is this deleted? This is being catch in Benchmark. I suspect this
> change
> > > may
> > > > be right if TestExpectation also handles platform mismatch failure.
> > > 
> > > This does not do anything useful. It catches it and them immediately
raises
> it
> > > again.
> > 
> > It is useful, because it is a subclass of page_test.Failure. Add a comment
> after
> > you restore this.
> 
> Then the solution sounds like it should not be a subclass of page_test.Failure

That was my thought too.

I changed the exception to TestNotSupportedOnPlatformError(Exception).

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (right):

https://codereview.chromium.org/755323012/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:288: msg='Exception
from TearDownState:')
On 2014/12/12 03:03:23, nednguyen wrote:
> On 2014/12/12 00:48:49, slamm wrote:
> > On 2014/12/05 01:57:02, chrishenry wrote:
> > > This logic and the logic above is the same, maybe extract a method called,
> > say,
> > > TearDownStateSafely(state)?
> > 
> > Done.
> 
> ping?

The logic ended up being different.

https://codereview.chromium.org/755323012/diff/140001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (right):

https://codereview.chromium.org/755323012/diff/140001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:256: raise
app_crash_exception  # require clean tear down
On 2014/12/12 00:59:25, chrishenry wrote:
> Can you make the comment clearer? What exactly does it mean by "clean tear
> down"?

I updated the logic and added better comments.

[nednguyen, 2014-12-12 19:07:52]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-12-12 19:08:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755323012/200001

[slamm, 2014-12-12 20:05:54]

The CQ bit was unchecked by slamm@chromium.org

[slamm, 2014-12-12 20:05:55]

On 2014/12/12 19:08:56, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/755323012/200001

A page_test unit test needs updating too.

[slamm, 2014-12-12 20:12:05]

Raise a Failure to have it caught

[slamm, 2014-12-12 20:12:14]

The CQ bit was checked by slamm@chromium.org

[commit-bot: I haz the power, 2014-12-12 20:13:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755323012/220001

[slamm, 2014-12-12 22:16:13]

Use DummyLocalUserSTory for app crash test.

[slamm, 2014-12-12 22:16:36]

The CQ bit was checked by slamm@chromium.org

[commit-bot: I haz the power, 2014-12-12 22:18:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755323012/240001

[slamm, 2014-12-13 00:02:14]

Fix unit tests on Linux

[slamm, 2014-12-13 00:02:50]

The CQ bit was checked by slamm@chromium.org

[commit-bot: I haz the power, 2014-12-13 00:03:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755323012/260001

[nednguyen, 2014-12-13 00:19:11]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2014-12-13 00:20:23]

https://codereview.chromium.org/755323012/diff/260001/tools/perf/measurements...
File tools/perf/measurements/smoothness_unittest.py (right):

https://codereview.chromium.org/755323012/diff/260001/tools/perf/measurements...
tools/perf/measurements/smoothness_unittest.py:178: except
exceptions.IntentionalException:
I am pretty sure that this is not the correct fix. The catch exception on the
left is for the case smoothness test isn't running on a supported platform.

[nednguyen, 2014-12-13 00:28:51]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-12-13 00:29:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755323012/260001

[nednguyen, 2014-12-13 00:30:36]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2014-12-13 00:33:12]

https://codereview.chromium.org/755323012/diff/260001/tools/perf/measurements...
File tools/perf/measurements/smoothness_unittest.py (right):

https://codereview.chromium.org/755323012/diff/260001/tools/perf/measurements...
tools/perf/measurements/smoothness_unittest.py:178: except
exceptions.IntentionalException:
On 2014/12/13 00:20:23, nednguyen wrote:
> I am pretty sure that this is not the correct fix. The catch exception on the
> left is for the case smoothness test isn't running on a supported platform.

nvm, TestNotSupportedOnPlatformFailure is only raised by screenshot. Not sure
what the catch statement was originally for.

[nednguyen, 2014-12-13 00:33:17]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-12-13 00:34:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755323012/260001

[slamm, 2014-12-13 01:22:25]

Really fix screenshot exception.

[slamm, 2014-12-13 01:23:27]

The CQ bit was checked by slamm@chromium.org

[commit-bot: I haz the power, 2014-12-13 01:25:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755323012/280001

[commit-bot: I haz the power, 2014-12-13 04:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-13 04:33:34]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nednguyen, 2014-12-13 07:03:45]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-12-13 07:04:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755323012/280001

[commit-bot: I haz the power, 2014-12-13 08:13:46]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2014-12-13 08:14:24]

Patchset 15 (id:??) landed as
https://crrev.com/68084e84746b6eebd9103be0f441c4e6441fbd15
Cr-Commit-Position: refs/heads/master@{#308258}