tools/perf/measurements/screenshot.py - Issue 755323012: [Telemetry] Stop execution for unexpected exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/screenshot.py

Issue 755323012: [Telemetry] Stop execution for unexpected exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Really fix screenshot exception. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/measurements/rasterize_and_record_micro_unittest.py ('k') | tools/perf/measurements/screenshot_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/measurements/screenshot.py

diff --git a/tools/perf/measurements/screenshot.py b/tools/perf/measurements/screenshot.py

index 5c4345a5a4ca397ed6c1f6b6d239f2da303d9081..49309b374e1390d1a1f701a7dabedabb88e4c642 100644

--- a/tools/perf/measurements/screenshot.py

+++ b/tools/perf/measurements/screenshot.py

@@ -17,7 +17,7 @@ class Screenshot(page_test.PageTest):

def ValidateAndMeasurePage(self, page, tab, results):

if not tab.screenshot_supported:

- raise page_test.TestNotSupportedOnPlatformFailure(

+ raise page_test.TestNotSupportedOnPlatformError(

'Browser does not support screenshotting')

tab.WaitForDocumentReadyStateToBeComplete()

« no previous file with comments | « tools/perf/measurements/rasterize_and_record_micro_unittest.py ('k') | tools/perf/measurements/screenshot_unittest.py » ('j') | no next file with comments »