tools/telemetry/telemetry/page/page_test_unittest.py - Issue 755323012: [Telemetry] Stop execution for unexpected exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test_unittest.py

Issue 755323012: [Telemetry] Stop execution for unexpected exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Really fix screenshot exception. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_test_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_test_unittest.py b/tools/telemetry/telemetry/page/page_test_unittest.py

index 5d2ec7d9ad3225e2b7f1a759912f1a50e026e265..2b40f92f20c8fcb49b614cd21d59abfbade971e9 100644

--- a/tools/telemetry/telemetry/page/page_test_unittest.py

+++ b/tools/telemetry/telemetry/page/page_test_unittest.py

@@ -18,7 +18,7 @@ from telemetry.wpr import archive_info

class PageTestThatFails(page_test.PageTest):

def ValidateAndMeasurePage(self, page, tab, results):

- raise exceptions.IntentionalException

+ raise page_test.Failure

class PageTestForBlank(page_test.PageTest):

« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | tools/telemetry/telemetry/unittest_util/page_test_test_case.py » ('j') | no next file with comments »