tools/perf/measurements/smoothness_unittest.py - Issue 755323012: [Telemetry] Stop execution for unexpected exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/smoothness_unittest.py

Issue 755323012: [Telemetry] Stop execution for unexpected exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Really fix screenshot exception. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/smoothness_unittest.py

diff --git a/tools/perf/measurements/smoothness_unittest.py b/tools/perf/measurements/smoothness_unittest.py

index 4a9ff7301160b8d20cf2a6089bf051c213ced7e8..572b1c2fcaf2cbf2ea5bc0a623298acb1f3498af 100644

--- a/tools/perf/measurements/smoothness_unittest.py

+++ b/tools/perf/measurements/smoothness_unittest.py

@@ -8,7 +8,6 @@ from metrics import power

from telemetry.core import exceptions

from telemetry.core import wpr_modes

from telemetry.page import page

-from telemetry.page import page_test

from telemetry.unittest_util import options_for_unittests

from telemetry.unittest_util import page_test_test_case

from telemetry.unittest_util import test

@@ -176,7 +175,7 @@ class SmoothnessUnitTest(page_test_test_case.PageTestTestCase):

measurement = BuggyMeasurement()

try:

self.RunMeasurement(measurement, ps)

- except page_test.TestNotSupportedOnPlatformFailure:

+ except exceptions.IntentionalException:

pass

self.assertTrue(measurement.fake_power.start_called)

« no previous file with comments | « tools/perf/measurements/screenshot_unittest.py ('k') | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »