Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 754873002: Add a second unsafe ES3 API in command buffer. (Closed)

Created:
6 years ago by Zhenyao Mo
Modified:
6 years ago
Reviewers:
bajones
CC:
chromium-reviews, Ken Russell (switch to Gerrit), piman+watch_chromium.org, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a second unsafe ES3 API in command buffer. glCopuBufferSubData Also, I disabled validator for unsafe functions. BUG=429053 TEST=gpu_unittests R=bajones@chromium.org TBR=sievers@chromium.org Committed: https://crrev.com/481d910f1191a34b185e0722a7284cb08503af85 Cr-Commit-Position: refs/heads/master@{#305522}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+459 lines, -285 lines) Patch
M gpu/GLES2/gl2chromium_autogen.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 3 chunks +9 lines, -13 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 1 chunk +59 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 1 chunk +182 lines, -181 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 2 chunks +21 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 1 3 chunks +12 lines, -59 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 2 chunks +35 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Zhenyao Mo
bajones: please review. kbr,vmiura: FYI. sievers: since the only file that this CL touches that ...
6 years ago (2014-11-24 18:40:57 UTC) #3
bajones
lgtm
6 years ago (2014-11-24 18:59:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754873002/60001
6 years ago (2014-11-24 21:23:03 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years ago (2014-11-24 23:52:45 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-24 23:53:27 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/481d910f1191a34b185e0722a7284cb08503af85
Cr-Commit-Position: refs/heads/master@{#305522}

Powered by Google App Engine
This is Rietveld 408576698