Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

Issue 754873002: Add a second unsafe ES3 API in command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h b/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
index 5cb603d51af764ca82032a22bcd3a7760c83624c..da5530e5918053f5ac92ef9c3c6a7adbbdfebee3 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
@@ -416,6 +416,27 @@ error::Error GLES2DecoderImpl::HandleCompressedTexSubImage2D(
return error::kNoError;
}
+error::Error GLES2DecoderImpl::HandleCopyBufferSubData(
+ uint32_t immediate_data_size,
+ const void* cmd_data) {
+ if (!unsafe_es3_apis_enabled())
+ return error::kUnknownCommand;
+ const gles2::cmds::CopyBufferSubData& c =
+ *static_cast<const gles2::cmds::CopyBufferSubData*>(cmd_data);
+ (void)c;
+ GLenum readtarget = static_cast<GLenum>(c.readtarget);
+ GLenum writetarget = static_cast<GLenum>(c.writetarget);
+ GLintptr readoffset = static_cast<GLintptr>(c.readoffset);
+ GLintptr writeoffset = static_cast<GLintptr>(c.writeoffset);
+ GLsizeiptr size = static_cast<GLsizeiptr>(c.size);
+ if (size < 0) {
+ LOCAL_SET_GL_ERROR(GL_INVALID_VALUE, "glCopyBufferSubData", "size < 0");
+ return error::kNoError;
+ }
+ glCopyBufferSubData(readtarget, writetarget, readoffset, writeoffset, size);
+ return error::kNoError;
+}
+
error::Error GLES2DecoderImpl::HandleCopyTexImage2D(
uint32_t immediate_data_size,
const void* cmd_data) {
@@ -811,16 +832,6 @@ error::Error GLES2DecoderImpl::HandleFramebufferTextureLayer(
GLuint texture = c.texture;
GLint level = static_cast<GLint>(c.level);
GLint layer = static_cast<GLint>(c.layer);
- if (!validators_->frame_buffer_target.IsValid(target)) {
- LOCAL_SET_GL_ERROR_INVALID_ENUM("glFramebufferTextureLayer", target,
- "target");
- return error::kNoError;
- }
- if (!validators_->attachment.IsValid(attachment)) {
- LOCAL_SET_GL_ERROR_INVALID_ENUM("glFramebufferTextureLayer", attachment,
- "attachment");
- return error::kNoError;
- }
DoFramebufferTextureLayer(target, attachment, texture, level, layer);
return error::kNoError;
}
« no previous file with comments | « gpu/command_buffer/common/gles2_cmd_ids_autogen.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698