Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 751573002: Use viewportConstrainedVisibleContentRect() to get the scrolling offset (Closed)

Created:
6 years ago by rtakacs
Modified:
6 years ago
Reviewers:
Ian Vollick, Xianzhu, trchen
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, blink-layers+watch_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use viewportConstrainedVisibleContentRect() to get the scrolling offset Renamed scrollOffsetForFixedPosition to scrollOffsetForViewportConstrainedObjects that uses viewportConstrainedVisibleContentRect() to get the scrolling offset already defined there. R=wangxianzhu@chromium.org TBR=aelias@chromium.org (Source/web one line change because of renaming) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187385

Patch Set 1 #

Patch Set 2 : Updated the patch #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Removed the 'DEPRECATED' comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M Source/core/frame/FrameView.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/paint/BoxPainter.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerClipper.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/FindInPageCoordinates.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
rtakacs
6 years ago (2014-11-21 12:48:18 UTC) #2
rtakacs
6 years ago (2014-11-25 19:39:18 UTC) #4
Xianzhu
The call sites look verbose. How about still keep scrollOffsetForFixedPosition() (perhaps renaming it to scrollOffsetForViewportConstrainedObjects()), ...
6 years ago (2014-11-25 19:46:33 UTC) #5
Xianzhu
Patch Set 3 lgtm (with one comment). https://codereview.chromium.org/751573002/diff/40001/Source/core/frame/FrameView.h File Source/core/frame/FrameView.h (right): https://codereview.chromium.org/751573002/diff/40001/Source/core/frame/FrameView.h#newcode310 Source/core/frame/FrameView.h:310: // DEPRECATED: ...
6 years ago (2014-12-11 19:59:26 UTC) #6
Xianzhu
Please also update the description of the change. On Thu, Dec 11, 2014 at 11:59 ...
6 years ago (2014-12-11 21:52:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751573002/60001
6 years ago (2014-12-17 13:13:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/22544)
6 years ago (2014-12-17 13:19:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751573002/60001
6 years ago (2014-12-17 16:59:14 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-17 17:03:04 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187385

Powered by Google App Engine
This is Rietveld 408576698