Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 751573002: Use viewportConstrainedVisibleContentRect() to get the scrolling offset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed the 'DEPRECATED' comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 // This function exists for ports that need to handle wheel events manually. 304 // This function exists for ports that need to handle wheel events manually.
305 // On Mac WebKit1 the underlying NSScrollView just does the scrolling, but o n most other platforms 305 // On Mac WebKit1 the underlying NSScrollView just does the scrolling, but o n most other platforms
306 // we need this function in order to do the scroll ourselves. 306 // we need this function in order to do the scroll ourselves.
307 bool wheelEvent(const PlatformWheelEvent&); 307 bool wheelEvent(const PlatformWheelEvent&);
308 308
309 bool inProgrammaticScroll() const { return m_inProgrammaticScroll; } 309 bool inProgrammaticScroll() const { return m_inProgrammaticScroll; }
310 void setInProgrammaticScroll(bool programmaticScroll) { m_inProgrammaticScro ll = programmaticScroll; } 310 void setInProgrammaticScroll(bool programmaticScroll) { m_inProgrammaticScro ll = programmaticScroll; }
311 311
312 virtual bool isActive() const override; 312 virtual bool isActive() const override;
313 313
314 // DEPRECATED: Use viewportConstrainedVisibleContentRect() instead. 314 IntSize scrollOffsetForViewportConstrainedObjects() const;
315 IntSize scrollOffsetForFixedPosition() const;
316 315
317 // Override scrollbar notifications to update the AXObject cache. 316 // Override scrollbar notifications to update the AXObject cache.
318 virtual void didAddScrollbar(Scrollbar*, ScrollbarOrientation) override; 317 virtual void didAddScrollbar(Scrollbar*, ScrollbarOrientation) override;
319 virtual void willRemoveScrollbar(Scrollbar*, ScrollbarOrientation) override; 318 virtual void willRemoveScrollbar(Scrollbar*, ScrollbarOrientation) override;
320 319
321 // FIXME: This should probably be renamed as the 'inSubtreeLayout' parameter 320 // FIXME: This should probably be renamed as the 'inSubtreeLayout' parameter
322 // passed around the FrameView layout methods can be true while this returns 321 // passed around the FrameView layout methods can be true while this returns
323 // false. 322 // false.
324 bool isSubtreeLayout() const { return !!m_layoutSubtreeRoot; } 323 bool isSubtreeLayout() const { return !!m_layoutSubtreeRoot; }
325 324
(...skipping 529 matching lines...) Expand 10 before | Expand all | Expand 10 after
855 } 854 }
856 855
857 private: 856 private:
858 RawPtrWillBeMember<FrameView> m_view; 857 RawPtrWillBeMember<FrameView> m_view;
859 bool m_originalValue; 858 bool m_originalValue;
860 }; 859 };
861 860
862 } // namespace blink 861 } // namespace blink
863 862
864 #endif // FrameView_h 863 #endif // FrameView_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698