Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: Source/web/FindInPageCoordinates.cpp

Issue 751573002: Use viewportConstrainedVisibleContentRect() to get the scrolling offset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed the 'DEPRECATED' comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderView.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/FindInPageCoordinates.cpp
diff --git a/Source/web/FindInPageCoordinates.cpp b/Source/web/FindInPageCoordinates.cpp
index eaeec4520c08f0711d11c367c137932bc0c93634..1b3288fc6909375042acf24e4f516478a6f3f35a 100644
--- a/Source/web/FindInPageCoordinates.cpp
+++ b/Source/web/FindInPageCoordinates.cpp
@@ -87,7 +87,7 @@ static FloatRect toNormalizedRect(const FloatRect& absoluteRect, const RenderObj
// Fixed positions do not make sense in this coordinate system, but need to leave consistent tickmarks.
// So, use their position when the view is not scrolled, like an absolute position.
if (renderer->style()->position() == FixedPosition && container->isRenderView())
- normalizedRect.move(-toRenderView(container)->frameView()->scrollOffsetForFixedPosition());
+ normalizedRect.move(-toRenderView(container)->frameView()->scrollOffsetForViewportConstrainedObjects());
normalizedRect.scale(1 / containerRect.width(), 1 / containerRect.height());
return normalizedRect;
« no previous file with comments | « Source/core/rendering/RenderView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698