Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 747493002: Revert "Adding or changing any of box-shadow, outline, or border-image-outset does not need a layou… (Closed)

Created:
6 years, 1 month ago by rhogan
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Revert "Adding or changing any of box-shadow, outline, or border-image-outset does not need a layout.." Revert https://codereview.chromium.org/561303002 until we get the overflow recalc path working properly with inline blocks and tables. BUG=434700, 434242, 431723 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185729

Patch Set 1 #

Patch Set 2 : Updated #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -313 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 1 comment Download
D LayoutTests/fast/layout/border-image-outset-no-relayout.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/layout/border-image-outset-no-relayout-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/layout/outline-no-relayout.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/layout/outline-no-relayout-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/layout/shadow-box-no-relayout.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/layout/shadow-box-no-relayout-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/repaint/border-image-outset-add-repaint.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/repaint/border-image-outset-add-repaint-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/repaint/border-image-outset-change-repaint.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/repaint/border-image-outset-change-repaint-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/repaint/box-shadow-add-repaint.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/repaint/box-shadow-add-repaint-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/repaint/box-shadow-change-repaint.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/repaint/box-shadow-change-repaint-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/repaint/outline-add-repaint.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/repaint/outline-add-repaint-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/repaint/outline-change-repaint.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/repaint/outline-change-repaint-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/outline-change-invalidation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/rendering/style/BorderData.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 5 chunks +9 lines, -10 lines 0 comments Download
M Source/core/rendering/style/StyleDifference.h View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rhogan
https://codereview.chromium.org/747493002/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/747493002/diff/20001/LayoutTests/TestExpectations#newcode366 LayoutTests/TestExpectations:366: crbug.com/396823 [ Mac ] virtual/regionbasedmulticol/fast/multicol/multicol-with-child-renderLayer-for-input.html [ ImageOnlyFailure ] No ...
6 years, 1 month ago (2014-11-20 21:04:43 UTC) #2
leviw_travelin_and_unemployed
Sad panda :( LGTM.
6 years, 1 month ago (2014-11-20 21:18:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747493002/20001
6 years, 1 month ago (2014-11-20 22:24:12 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 00:18:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185729

Powered by Google App Engine
This is Rietveld 408576698