Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 747493002: Revert "Adding or changing any of box-shadow, outline, or border-image-outset does not need a layou… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1670 matching lines...) Expand 10 before | Expand all | Expand 10 after
1681 setNeedsLayoutAndPrefWidthsRecalc(); 1681 setNeedsLayoutAndPrefWidthsRecalc();
1682 else if (updatedDiff.needsPositionedMovementLayout()) 1682 else if (updatedDiff.needsPositionedMovementLayout())
1683 setNeedsPositionedMovementLayout(); 1683 setNeedsPositionedMovementLayout();
1684 } 1684 }
1685 1685
1686 if (diff.transformChanged() && !needsLayout()) { 1686 if (diff.transformChanged() && !needsLayout()) {
1687 if (RenderBlock* container = containingBlock()) 1687 if (RenderBlock* container = containingBlock())
1688 container->setNeedsOverflowRecalcAfterStyleChange(); 1688 container->setNeedsOverflowRecalcAfterStyleChange();
1689 } 1689 }
1690 1690
1691 if (diff.visualOverflowChanged() && !needsLayout()) {
1692 // FIXME crbug.com/425610: Compute overflow without layout for line boxe s too.
1693 if (isRenderBlock())
1694 setNeedsOverflowRecalcAfterStyleChange();
1695 else
1696 setNeedsLayoutAndPrefWidthsRecalc();
1697 }
1698
1699 if (updatedDiff.needsPaintInvalidationLayer()) 1691 if (updatedDiff.needsPaintInvalidationLayer())
1700 toRenderLayerModelObject(this)->layer()->setShouldDoFullPaintInvalidatio nIncludingNonCompositingDescendants(); 1692 toRenderLayerModelObject(this)->layer()->setShouldDoFullPaintInvalidatio nIncludingNonCompositingDescendants();
1701 else if (diff.needsPaintInvalidationObject() || updatedDiff.needsPaintInvali dationObject()) 1693 else if (diff.needsPaintInvalidationObject() || updatedDiff.needsPaintInvali dationObject())
1702 setShouldDoFullPaintInvalidation(); 1694 setShouldDoFullPaintInvalidation();
1703 } 1695 }
1704 1696
1705 static inline bool rendererHasBackground(const RenderObject* renderer) 1697 static inline bool rendererHasBackground(const RenderObject* renderer)
1706 { 1698 {
1707 return renderer && renderer->hasBackground(); 1699 return renderer && renderer->hasBackground();
1708 } 1700 }
(...skipping 1439 matching lines...) Expand 10 before | Expand all | Expand 10 after
3148 { 3140 {
3149 if (object1) { 3141 if (object1) {
3150 const blink::RenderObject* root = object1; 3142 const blink::RenderObject* root = object1;
3151 while (root->parent()) 3143 while (root->parent())
3152 root = root->parent(); 3144 root = root->parent();
3153 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3145 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3154 } 3146 }
3155 } 3147 }
3156 3148
3157 #endif 3149 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698