Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 561303002: Style changes to visual overflow do not require a layout (Closed)

Created:
6 years, 3 months ago by rhogan
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Adding or changing any of box-shadow, outline, or border-image-outset does not need a layout.. .. so just require a paint invalidation and ensure visual overflow gets recomputed. There is an optimization that throttles paint invalidations on an element when the children have just been laid out - now that we avoid this layout we want to continue throttling these repaints. I will address this in a follow-up. BUG=396825 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183698

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : Make tests work on Mac and Win #

Total comments: 1

Patch Set 4 : Updated per epsrehn's comments #

Patch Set 5 : Updated #

Total comments: 1

Patch Set 6 : Updated #

Patch Set 7 : Updated #

Patch Set 8 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -27 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/layout/border-image-outset-no-relayout.html View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A + LayoutTests/fast/layout/border-image-outset-no-relayout-expected.txt View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/fast/layout/outline-no-relayout.html View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A + LayoutTests/fast/layout/outline-no-relayout-expected.txt View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/fast/layout/shadow-box-no-relayout.html View 1 chunk +17 lines, -0 lines 0 comments Download
A + LayoutTests/fast/layout/shadow-box-no-relayout-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/fast/repaint/border-image-outset-add-repaint.html View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/border-image-outset-add-repaint-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/repaint/border-image-outset-change-repaint.html View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/border-image-outset-change-repaint-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/repaint/box-shadow-add-repaint.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/box-shadow-add-repaint-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/repaint/box-shadow-change-repaint.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/box-shadow-change-repaint-expected.txt View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A LayoutTests/fast/repaint/outline-add-repaint.html View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/outline-add-repaint-expected.txt View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
A LayoutTests/fast/repaint/outline-change-repaint.html View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/outline-change-repaint-expected.txt View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/outline-change-invalidation-expected.txt View 1 2 3 4 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/svg/repaint/add-outline-property-on-root-expected.txt View 1 2 3 4 1 chunk +1 line, -7 lines 0 comments Download
M LayoutTests/platform/linux/svg/repaint/remove-outline-property-on-root-expected.txt View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/style/BorderData.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 3 4 5 chunks +10 lines, -9 lines 0 comments Download
M Source/core/rendering/style/StyleDifference.h View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
rhogan
6 years, 3 months ago (2014-09-17 18:24:54 UTC) #2
esprehn
This is not correct, now the visualOverflow on the renderer will be wrong. There is ...
6 years, 3 months ago (2014-09-18 20:08:14 UTC) #4
leviw_travelin_and_unemployed
This LGTM with a question! https://codereview.chromium.org/561303002/diff/80001/LayoutTests/platform/linux/fast/repaint/outline-change-invalidation-expected.txt File LayoutTests/platform/linux/fast/repaint/outline-change-invalidation-expected.txt (right): https://codereview.chromium.org/561303002/diff/80001/LayoutTests/platform/linux/fast/repaint/outline-change-invalidation-expected.txt#newcode9 LayoutTests/platform/linux/fast/repaint/outline-change-invalidation-expected.txt:9: [792, 16, 5, 97], ...
6 years, 2 months ago (2014-10-10 23:27:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/561303002/310001
6 years, 2 months ago (2014-10-14 20:18:44 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 21:58:23 UTC) #8
Message was sent while issue was closed. 
Committed patchset #8 (id:310001) as 183698

Powered by Google App Engine
This is Rietveld 408576698