Source/core/rendering/RenderObject.cpp - Issue 747493002: Revert "Adding or changing any of box-shadow, outline, or border-image-outset does not need a layou…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 747493002: Revert "Adding or changing any of box-shadow, outline, or border-image-outset does not need a layou… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/platform/linux/fast/repaint/outline-change-invalidation-expected.txt ('k') | Source/core/rendering/style/BorderData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderObject.cpp

diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp

index ed9585fe0f2c3cdeaff5780f28c637af60d38eae..5cdce6e0d42bac59859fe6acb7527b2c3d0f0343 100644

--- a/Source/core/rendering/RenderObject.cpp

+++ b/Source/core/rendering/RenderObject.cpp

@@ -1688,14 +1688,6 @@ void RenderObject::setStyle(PassRefPtr<RenderStyle> style)

container->setNeedsOverflowRecalcAfterStyleChange();

}

- if (diff.visualOverflowChanged() && !needsLayout()) {

- // FIXME crbug.com/425610: Compute overflow without layout for line boxes too.

- if (isRenderBlock())

- setNeedsOverflowRecalcAfterStyleChange();

- else

- setNeedsLayoutAndPrefWidthsRecalc();

- }

if (updatedDiff.needsPaintInvalidationLayer())

toRenderLayerModelObject(this)->layer()->setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants();

else if (diff.needsPaintInvalidationObject() || updatedDiff.needsPaintInvalidationObject())