Fix WeakPtrFactory member ordering in extensions

Fix WeakPtrFactory member ordering in extensions

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818
Committed: https://crrev.com/12e960dfab78bcbd6e773a2af5544c0d19d4f89b
Cr-Commit-Position: refs/heads/master@{#305633}

[MRV, 2014-11-20 14:36:07]

mohan.reddy@samsung.com changed reviewers:
+ kalman@chromium.org

[MRV, 2014-11-20 14:36:38]

On 2014/11/20 14:36:07, MRV wrote:
> mailto:mohan.reddy@samsung.com changed reviewers:
> + mailto:kalman@chromium.org

PTAL.

[not at google - send to devlin, 2014-11-20 15:30:30]

https://codereview.chromium.org/744663002/diff/1/extensions/browser/api/decla...
File extensions/browser/api/declarative/rules_registry.cc (right):

https://codereview.chromium.org/744663002/diff/1/extensions/browser/api/decla...
extensions/browser/api/declarative/rules_registry.cc:72:
RulesRegistry::RulesRegistry(content::BrowserContext *browser_context,
Please don't arbitrarily change style like this. Besides which, this style is
against Chromium style rules.

https://codereview.chromium.org/744663002/diff/1/extensions/browser/app_windo...
File extensions/browser/app_window/app_window.cc (right):

https://codereview.chromium.org/744663002/diff/1/extensions/browser/app_windo...
extensions/browser/app_window/app_window.cc:230:
AppWindow::AppWindow(BrowserContext *context, AppDelegate *app_delegate,
Same?

[MRV, 2014-11-21 11:12:39]

Thanks mr. kalman for your feedback.
I got following presubmit error, after running "git cl format", it had made
changes like that.
The browser directory requires clang-formatting. Please run git cl format
browser

I have made my changes as you suugested now.
PTAL.

https://codereview.chromium.org/744663002/diff/1/extensions/browser/api/decla...
File extensions/browser/api/declarative/rules_registry.cc (right):

https://codereview.chromium.org/744663002/diff/1/extensions/browser/api/decla...
extensions/browser/api/declarative/rules_registry.cc:72:
RulesRegistry::RulesRegistry(content::BrowserContext *browser_context,
On 2014/11/20 15:30:30, kalman wrote:
> Please don't arbitrarily change style like this. Besides which, this style is
> against Chromium style rules.

@Kalman, while uploading patch using "git cl upload"
I got presubmit error asking to use "git cl format" as per clang, i use the
same, it has changed the styles like this.
I'll keep existing style and upload patch again.

https://codereview.chromium.org/744663002/diff/1/extensions/browser/app_windo...
File extensions/browser/app_window/app_window.cc (right):

https://codereview.chromium.org/744663002/diff/1/extensions/browser/app_windo...
extensions/browser/app_window/app_window.cc:230:
AppWindow::AppWindow(BrowserContext *context, AppDelegate *app_delegate,
On 2014/11/20 15:30:30, kalman wrote:
> Same?

I'll change as original style.

[not at google - send to devlin, 2014-11-21 21:38:03]

lgtm, but if that's what git cl format changed your code to, then you're running
with a misconfigured clang-format or something.

[MRV, 2014-11-22 07:39:13]

On 2014/11/21 21:38:03, kalman wrote:
> lgtm, but if that's what git cl format changed your code to, then you're
running
> with a misconfigured clang-format or something.

Thanks mr.kalman for your review and feeback.
I'll reconfigure my clang-format.

[MRV, 2014-11-22 07:39:21]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-11-22 07:40:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/744663002/20001

[commit-bot: I haz the power, 2014-11-22 08:19:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-22 08:19:28]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[MRV, 2014-11-22 09:57:15]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-11-22 09:58:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/744663002/20001

[commit-bot: I haz the power, 2014-11-22 10:32:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-22 10:32:50]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[MRV, 2014-11-25 13:10:06]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-11-25 13:10:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/744663002/20001

[commit-bot: I haz the power, 2014-11-25 13:56:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-25 13:57:32]

Patchset 2 (id:??) landed as
https://crrev.com/12e960dfab78bcbd6e773a2af5544c0d19d4f89b
Cr-Commit-Position: refs/heads/master@{#305633}