Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 744663002: Fix WeakPtrFactory member ordering in extensions (Closed)

Created:
6 years, 1 month ago by MRV
Modified:
6 years ago
CC:
chromium-reviews, dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member ordering in extensions Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/12e960dfab78bcbd6e773a2af5544c0d19d4f89b Cr-Commit-Position: refs/heads/master@{#305633}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporated changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M extensions/browser/api/declarative/rules_registry.h View 2 chunks +13 lines, -13 lines 0 comments Download
M extensions/browser/api/declarative/rules_registry.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/app_window/app_window.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
MRV
On 2014/11/20 14:36:07, MRV wrote: > mailto:mohan.reddy@samsung.com changed reviewers: > + mailto:kalman@chromium.org PTAL.
6 years, 1 month ago (2014-11-20 14:36:38 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/744663002/diff/1/extensions/browser/api/declarative/rules_registry.cc File extensions/browser/api/declarative/rules_registry.cc (right): https://codereview.chromium.org/744663002/diff/1/extensions/browser/api/declarative/rules_registry.cc#newcode72 extensions/browser/api/declarative/rules_registry.cc:72: RulesRegistry::RulesRegistry(content::BrowserContext *browser_context, Please don't arbitrarily change style like this. ...
6 years, 1 month ago (2014-11-20 15:30:30 UTC) #3
MRV
Thanks mr. kalman for your feedback. I got following presubmit error, after running "git cl ...
6 years, 1 month ago (2014-11-21 11:12:39 UTC) #4
not at google - send to devlin
lgtm, but if that's what git cl format changed your code to, then you're running ...
6 years, 1 month ago (2014-11-21 21:38:03 UTC) #5
MRV
On 2014/11/21 21:38:03, kalman wrote: > lgtm, but if that's what git cl format changed ...
6 years, 1 month ago (2014-11-22 07:39:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744663002/20001
6 years, 1 month ago (2014-11-22 07:40:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/83231)
6 years, 1 month ago (2014-11-22 08:19:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744663002/20001
6 years, 1 month ago (2014-11-22 09:58:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/83276)
6 years, 1 month ago (2014-11-22 10:32:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744663002/20001
6 years ago (2014-11-25 13:10:55 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-25 13:56:41 UTC) #17
commit-bot: I haz the power
6 years ago (2014-11-25 13:57:32 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12e960dfab78bcbd6e773a2af5544c0d19d4f89b
Cr-Commit-Position: refs/heads/master@{#305633}

Powered by Google App Engine
This is Rietveld 408576698