Fix WeakPtrFactory member ordering in extensions

extensions/browser/api/declarative/rules_registry.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/declarative/rules_registry.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 51 matching lines @@
   return base::StringPrintf("_%d_", identifier);
 }
 
 }  // namespace
 
 
 namespace extensions {
 
 // RulesRegistry
 
-RulesRegistry::RulesRegistry(content::BrowserContext* browser_context,
-                             const std::string& event_name,
+RulesRegistry::RulesRegistry(content::BrowserContext *browser_context,

[not at google - send to devlin, 2014/11/20 15:30:30]

Please don't arbitrarily change style like this. Besides which, this style is
against Chromium style rules.

[MRV, 2014/11/21 11:12:39]

@Kalman, while uploading patch using "git cl upload"
I got presubmit error asking to use "git cl format" as per clang, i use the
same, it has changed the styles like this.
I'll keep existing style and upload patch again.

+                             const std::string &event_name,
                              content::BrowserThread::ID owner_thread,
-                             RulesCacheDelegate* cache_delegate,
-                             const WebViewKey& webview_key)
-    : browser_context_(browser_context),
-      owner_thread_(owner_thread),
-      event_name_(event_name),
-      webview_key_(webview_key),
-      ready_(/*signaled=*/!cache_delegate),  // Immediately ready if no cache
-                                             // delegate to wait for.
-      weak_ptr_factory_(browser_context_ ? this : NULL),
-      last_generated_rule_identifier_id_(0) {
+                             RulesCacheDelegate *cache_delegate,
+                             const WebViewKey &webview_key)
+    : browser_context_(browser_context), owner_thread_(owner_thread),
+      event_name_(event_name), webview_key_(webview_key),
+      ready_(/*signaled=*/!cache_delegate), // Immediately ready if no cache
+                                            // delegate to wait for.
+      last_generated_rule_identifier_id_(0),
+      weak_ptr_factory_(browser_context_ ? this : NULL) {
   if (cache_delegate) {
     cache_delegate_ = cache_delegate->GetWeakPtr();
     cache_delegate->Init(this);
   }
 }
 
 std::string RulesRegistry::AddRulesNoFill(
     const std::string& extension_id,
     const std::vector<linked_ptr<Rule> >& rules) {
   DCHECK_CURRENTLY_ON(owner_thread());
@@ skipping 273 matching lines @@
   for (i = identifiers.begin(); i != identifiers.end(); ++i)
     used_rule_identifiers_[extension_id].erase(*i);
 }
 
 void RulesRegistry::RemoveAllUsedRuleIdentifiers(
     const std::string& extension_id) {
   used_rule_identifiers_.erase(extension_id);
 }
 
 }  // namespace extensions