extensions/browser/api/declarative/rules_registry.cc - Issue 744663002: Fix WeakPtrFactory member ordering in extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/rules_registry.cc

Issue 744663002: Fix WeakPtrFactory member ordering in extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated changes Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/declarative/rules_registry.cc

diff --git a/extensions/browser/api/declarative/rules_registry.cc b/extensions/browser/api/declarative/rules_registry.cc

index ececdfdaa85cda66bbf7f600c0926cc6c78c8487..68aa434682fd610c93418b4362a2e9efe19595c6 100644

--- a/extensions/browser/api/declarative/rules_registry.cc

+++ b/extensions/browser/api/declarative/rules_registry.cc

@@ -80,8 +80,8 @@ RulesRegistry::RulesRegistry(content::BrowserContext* browser_context,

webview_key_(webview_key),

ready_(/*signaled=*/!cache_delegate), // Immediately ready if no cache

// delegate to wait for.

- weak_ptr_factory_(browser_context_ ? this : NULL),

- last_generated_rule_identifier_id_(0) {

+ last_generated_rule_identifier_id_(0),

+ weak_ptr_factory_(browser_context_ ? this : NULL) {

if (cache_delegate) {

cache_delegate_ = cache_delegate->GetWeakPtr();

cache_delegate->Init(this);