Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: extensions/browser/app_window/app_window.h

Issue 744663002: Fix WeakPtrFactory member ordering in extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated changes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/declarative/rules_registry.cc ('k') | extensions/browser/app_window/app_window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/app_window.h
diff --git a/extensions/browser/app_window/app_window.h b/extensions/browser/app_window/app_window.h
index 12029c79744317232f74ea411776b18e9f9f1d61..98f3c8c0b031016d8ff09115c12a0a2173e3e987 100644
--- a/extensions/browser/app_window/app_window.h
+++ b/extensions/browser/app_window/app_window.h
@@ -509,8 +509,6 @@ class AppWindow : public content::NotificationObserver,
// app window.
scoped_ptr<web_modal::PopupManager> popup_manager_;
- base::WeakPtrFactory<AppWindow> image_loader_ptr_factory_;
-
// Bit field of FullscreenType.
int fullscreen_types_;
@@ -548,6 +546,8 @@ class AppWindow : public content::NotificationObserver,
// Whether |alpha_enabled| was set in the CreateParams.
bool requested_alpha_enabled_;
+ base::WeakPtrFactory<AppWindow> image_loader_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(AppWindow);
};
« no previous file with comments | « extensions/browser/api/declarative/rules_registry.cc ('k') | extensions/browser/app_window/app_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698