Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 743813002: Take #2 at re-enabling breakpad in the Mac GN build. (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
brettw, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Take #2 at re-enabling breakpad in the Mac GN build. The previous version failed because we seem to have rolled in a new version of breakpad that had an unused function error in a target that was previously compiling fine w/ the chromium_code config. This patch marks the target (symupload) as no_chromium_code. TBR=brettw@chromium.org BUG=431177 Committed: https://crrev.com/6326e8d4fb73dc09ff104828fd0d82c32acc514e Cr-Commit-Position: refs/heads/master@{#304980}

Patch Set 1 : original patch #

Patch Set 2 : build fix for symupload #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M breakpad/BUILD.gn View 1 4 chunks +9 lines, -6 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
6 years, 1 month ago (2014-11-20 01:20:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743813002/20001
6 years, 1 month ago (2014-11-20 03:50:07 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 04:58:56 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6326e8d4fb73dc09ff104828fd0d82c32acc514e Cr-Commit-Position: refs/heads/master@{#304980}
6 years, 1 month ago (2014-11-20 04:59:33 UTC) #5
Nico
https://codereview.chromium.org/743813002/diff/20001/breakpad/BUILD.gn File breakpad/BUILD.gn (right): https://codereview.chromium.org/743813002/diff/20001/breakpad/BUILD.gn#newcode232 breakpad/BUILD.gn:232: configs += [ "//build/config/compiler:no_chromium_code" ] Is there a way ...
6 years, 1 month ago (2014-11-20 17:45:38 UTC) #7
brettw
6 years, 1 month ago (2014-11-20 18:46:27 UTC) #8
Message was sent while issue was closed.
No, sadly this is per-target.

Powered by Google App Engine
This is Rietveld 408576698