BUILD.gn - Issue 743813002: Take #2 at re-enabling breakpad in the Mac GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 743813002: Take #2 at re-enabling breakpad in the Mac GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build fix for symupload Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 5206979d1d6b7a36bc1eae114606cb33354c18df..d4681d31a16d77eab711e468c71b29d33d3dcc4b 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -273,11 +273,6 @@ group("root") {

if (is_mac) {

- # TODO(dpranke): Need to fix the unused function errors in breakpad.

- deps -= [

- "//breakpad:symupload"

- ]

# TODO(dpranke): These need a webrtc fix in order to build.

deps -= [

"//jingle:notifier",

« no previous file with comments | « no previous file | breakpad/BUILD.gn » ('j') | breakpad/BUILD.gn » ('J')