Take #2 at re-enabling breakpad in the Mac GN build.

breakpad/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 config("tools_config") {
   include_dirs = [ "src", "src/third_party" ]
   if (is_android) {
     defines = [ "__ANDROID__" ]
   }
   if (is_clang) {
@@ skipping 209 matching lines @@
     sources = [
       "src/common/mac/HTTPMultipartUpload.m",
       "src/tools/mac/symupload/symupload.m",
     ]
 
     include_dirs = [
       "src/common/mac"
     ]
 
     libs = [ "Foundation.framework" ]
+
+    configs -= [ "//build/config/compiler:chromium_code" ]
+    configs += [ "//build/config/compiler:no_chromium_code" ]

[Nico, 2014/11/20 17:45:38]

Is there a way to mark all targets in this file as no_chromium_code? That would
match gyp.

   }
 }
 
 if (is_mac) {
   static_library("utilities") {
     sources = [
       "src/client/mac/crash_generation/ConfigFile.mm",
       "src/client/mac/handler/breakpad_nlist_64.cc",
       "src/client/mac/handler/dynamic_images.cc",
       "src/client/mac/handler/minidump_generator.cc",
       "src/client/minidump_file_writer.cc",
       "src/common/convert_UTF.c",
       "src/common/mac/MachIPC.mm",
       "src/common/mac/arch_utilities.cc",
       "src/common/mac/bootstrap_compat.cc",
       "src/common/mac/file_id.cc",
       "src/common/mac/launch_reporter.cc",
       "src/common/mac/macho_id.cc",
       "src/common/mac/macho_utilities.cc",
       "src/common/mac/macho_walker.cc",
       "src/common/mac/string_utilities.cc",
       "src/common/md5.cc",
       "src/common/simple_string_dictionary.cc",
       "src/common/string_conversion.cc",
     ]
 
     configs += [ ":internal_config" ]
     
-    # TODO(GYP): TODO(dpranke): Fix the compile for this.
-    sources -= [
-      "src/client/mac/handler/dynamic_images.cc",
-    ]
+    # There are some warnings in this code.
+    configs -= [ "//build/config/compiler:chromium_code" ]
+    configs += [ "//build/config/compiler:no_chromium_code" ]
   }
 
   executable("crash_inspector") {
     sources = [
       "src/client/mac/crash_generation/Inspector.mm",
       "src/client/mac/crash_generation/InspectorMain.mm",
     ]
 
     # TODO(GYP): 'mac_real_dsym': 1,
 
     include_dirs = [
       "src/client/apple/Framework",
       "src/common/mac",
       "src",
     ]
     libs = [
       "CoreServices.framework",
       "Foundation.framework",
     ]
 
     deps = [
       ":utilities"
     ]
   }
 
   # TODO(GYP) this target has some mac_bundle_resources stuff.
   # executable("crash_report_sender") {
   # }
+  group("crash_report_sender") {
+  }
 
   config("breakpad_config") {
     include_dirs = [ "src/client/apple/Framework" ]
   }
 
   static_library("breakpad") {
     sources = [
       "src/client/mac/crash_generation/crash_generation_client.cc",
       "src/client/mac/crash_generation/crash_generation_client.h",
       "src/client/mac/handler/protected_memory_allocator.cc",
       "src/client/mac/handler/exception_handler.cc",
       "src/client/mac/Framework/Breakpad.mm",
       "src/client/mac/Framework/OnDemandServer.mm",
     ]
 
     configs += [ ":internal_config" ]
     public_configs = [ ":breakpad_config" ]
 
     defines = [ "USE_PROTECTED_ALLOCATIONS=1" ]
     include_dirs = [
       "src/client/apple/Framework",
     ]
 
     deps = [
       ":utilities",
       ":crash_inspector",
-      # TODO(GYP): Make this link
-      #":crash_report_sender",
+      ":crash_report_sender",
     ]
   }
 
   group("client") {
     public_configs = [ ":client_config" ]
   }
 }
 
 if (is_linux) {
   executable("symupload") {
@@ skipping 390 matching lines @@
       "src/client/windows/handler/exception_handler.h",
       "src/common/windows/guid_string.cc",
       "src/common/windows/guid_string.h",
       "src/google_breakpad/common/minidump_format.h",
       "src/client/windows/crash_generation/minidump_generator.cc",
       "src/client/windows/crash_generation/minidump_generator.h",
       "src/common/windows/string_utils-inl.h",
     ]
   }
 }