Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: BUILD.gn

Issue 743813002: Take #2 at re-enabling breakpad in the Mac GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix for symupload Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | breakpad/BUILD.gn » ('j') | breakpad/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 "//device/usb", 266 "//device/usb",
267 "//third_party/pdfium/samples", 267 "//third_party/pdfium/samples",
268 ] 268 ]
269 } 269 }
270 270
271 # 271 #
272 # TODO(GYP): Make everything below this work in the GN build. 272 # TODO(GYP): Make everything below this work in the GN build.
273 # 273 #
274 274
275 if (is_mac) { 275 if (is_mac) {
276 # TODO(dpranke): Need to fix the unused function errors in breakpad.
277 deps -= [
278 "//breakpad:symupload"
279 ]
280
281 # TODO(dpranke): These need a webrtc fix in order to build. 276 # TODO(dpranke): These need a webrtc fix in order to build.
282 deps -= [ 277 deps -= [
283 "//jingle:notifier", 278 "//jingle:notifier",
284 "//third_party/libjingle", 279 "//third_party/libjingle",
285 "//third_party/webrtc", 280 "//third_party/webrtc",
286 ] 281 ]
287 282
288 # TODO(dpranke): These depend on Blink and need Blink fixes to build. 283 # TODO(dpranke): These depend on Blink and need Blink fixes to build.
289 deps -= [ 284 deps -= [
290 "//cc/blink", 285 "//cc/blink",
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 "//ui/native_theme", 376 "//ui/native_theme",
382 "//ui/snapshot", 377 "//ui/snapshot",
383 "//ui/surface", 378 "//ui/surface",
384 "//ui/views", 379 "//ui/views",
385 "//ui/views/controls/webview", 380 "//ui/views/controls/webview",
386 "//ui/web_dialogs", 381 "//ui/web_dialogs",
387 "//ui/wm", 382 "//ui/wm",
388 ] 383 ]
389 } 384 }
390 } 385 }
OLDNEW
« no previous file with comments | « no previous file | breakpad/BUILD.gn » ('j') | breakpad/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698