Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 737633002: Fix various flags in the Win64 GN build (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix various flags in the Win64 GN build -disable chromium_code for third_party/zlib - suppress a few size_t -> int conversion warnings - suppress /wd4121 (structure padding) by default; was suppressed in GYP but not GN. Also disable ffmpeg, which doesn't work in the 64-bit build yet. R=scottmg@chromium.org TBR=brettw@chromium.org BUG=432375, 167187 Committed: https://crrev.com/de7d0dc942b1e296a0e9bd667f020ffd486cc32e Cr-Commit-Position: refs/heads/master@{#304542}

Patch Set 1 #

Patch Set 2 : tweak more flags to better match GYP #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +1 line, -0 lines 1 comment Download
M rlz/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/zlib/BUILD.gn View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
Dirk Pranke
6 years, 1 month ago (2014-11-17 23:22:37 UTC) #1
scottmg
lgtm
6 years, 1 month ago (2014-11-17 23:25:48 UTC) #2
Dirk Pranke
Please take another look? This has a couple additional changes, so I've updated the description.
6 years, 1 month ago (2014-11-18 00:59:39 UTC) #3
scottmg
https://codereview.chromium.org/737633002/diff/20001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/737633002/diff/20001/build/config/compiler/BUILD.gn#newcode693 build/config/compiler/BUILD.gn:693: "/wd4121", # Alignment of a member was sensitive to ...
6 years, 1 month ago (2014-11-18 01:01:13 UTC) #4
scottmg
sorry, just missed it. still lgtm.
6 years, 1 month ago (2014-11-18 01:01:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737633002/20001
6 years, 1 month ago (2014-11-18 01:08:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/24798)
6 years, 1 month ago (2014-11-18 01:13:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737633002/20001
6 years, 1 month ago (2014-11-18 01:30:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/24804)
6 years, 1 month ago (2014-11-18 01:34:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737633002/20001
6 years, 1 month ago (2014-11-18 01:43:41 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-18 01:55:04 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 01:55:37 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de7d0dc942b1e296a0e9bd667f020ffd486cc32e
Cr-Commit-Position: refs/heads/master@{#304542}

Powered by Google App Engine
This is Rietveld 408576698