Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/zlib/BUILD.gn

Issue 737633002: Fix various flags in the Win64 GN build (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweak more flags to better match GYP Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/compiler/BUILD.gn ('K') | « rlz/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/zlib/BUILD.gn
diff --git a/third_party/zlib/BUILD.gn b/third_party/zlib/BUILD.gn
index 5dbec0ff6bf3cad30fdaf8f240a3ba92464ef392..d07fd9a38706fb126d934db85429c42fcc3180dc 100644
--- a/third_party/zlib/BUILD.gn
+++ b/third_party/zlib/BUILD.gn
@@ -12,11 +12,10 @@ static_library("zlib_x86_simd") {
cflags = [ "-msse2", "-msse4.2", "-mpclmul" ]
} else {
sources = [ "simd_stub.c"]
- if (is_win) {
- # TODO(GYP): crbug.com/431462 disable warning about structure padding.
- cflags = [ "/wd4324" ]
- }
}
+
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
}
static_library("zlib") {
« build/config/compiler/BUILD.gn ('K') | « rlz/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698