Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: rlz/BUILD.gn

Issue 737633002: Fix various flags in the Win64 GN build (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweak more flags to better match GYP Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: rlz/BUILD.gn
diff --git a/rlz/BUILD.gn b/rlz/BUILD.gn
index 3a23d7d057e2835354a5118ce1ccc9bc4cb425d2..0887ef4726a3d8ab64e91a8df8a2de5c01395bfd 100644
--- a/rlz/BUILD.gn
+++ b/rlz/BUILD.gn
@@ -114,6 +114,11 @@ test("rlz_unittests") {
"//testing/gtest",
"//third_party/zlib",
]
+
+ if (is_win) {
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ cflags = [ "/wd4267" ]
+ }
}
executable("rlz_id") {

Powered by Google App Engine
This is Rietveld 408576698