Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 737633002: Fix various flags in the Win64 GN build (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweak more flags to better match GYP Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/BUILD.gn ('k') | rlz/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 if (cpu_arch == "arm") { 6 if (cpu_arch == "arm") {
7 import("//build/config/arm.gni") 7 import("//build/config/arm.gni")
8 } 8 }
9 if (is_posix) { 9 if (is_posix) {
10 import("//build/config/gcc/gcc_version.gni") 10 import("//build/config/gcc/gcc_version.gni")
(...skipping 672 matching lines...) Expand 10 before | Expand all | Expand 10 after
683 # Chromium code compiles without exception support. We therefore have to 683 # Chromium code compiles without exception support. We therefore have to
684 # use setjmp/longjmp for e.g. JPEG decode error handling, which means we 684 # use setjmp/longjmp for e.g. JPEG decode error handling, which means we
685 # have to turn off this warning (and be careful about how object 685 # have to turn off this warning (and be careful about how object
686 # destruction happens in such cases). 686 # destruction happens in such cases).
687 "/wd4611", 687 "/wd4611",
688 688
689 689
690 # Warnings to evaluate and possibly fix/reenable later: 690 # Warnings to evaluate and possibly fix/reenable later:
691 691
692 "/wd4100", # Unreferenced formal function parameter. 692 "/wd4100", # Unreferenced formal function parameter.
693 "/wd4121", # Alignment of a member was sensitive to packing.
scottmg 2014/11/18 01:01:13 I don't see this one in gyp?
693 "/wd4189", # A variable was declared and initialized but never used. 694 "/wd4189", # A variable was declared and initialized but never used.
694 "/wd4244", # Conversion: possible loss of data. 695 "/wd4244", # Conversion: possible loss of data.
695 "/wd4481", # Nonstandard extension: override specifier. 696 "/wd4481", # Nonstandard extension: override specifier.
696 "/wd4505", # Unreferenced local function has been removed. 697 "/wd4505", # Unreferenced local function has been removed.
697 "/wd4510", # Default constructor could not be generated. 698 "/wd4510", # Default constructor could not be generated.
698 "/wd4512", # Assignment operator could not be generated. 699 "/wd4512", # Assignment operator could not be generated.
699 "/wd4610", # Class can never be instantiated, constructor required. 700 "/wd4610", # Class can never be instantiated, constructor required.
700 "/wd4996", # Deprecated function warning. 701 "/wd4996", # Deprecated function warning.
701 ] 702 ]
702 } else { 703 } else {
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
970 cflags += [ "-gsplit-dwarf" ] 971 cflags += [ "-gsplit-dwarf" ]
971 } 972 }
972 } 973 }
973 } 974 }
974 975
975 config("no_symbols") { 976 config("no_symbols") {
976 if (!is_win) { 977 if (!is_win) {
977 cflags = [ "-g0" ] 978 cflags = [ "-g0" ]
978 } 979 }
979 } 980 }
OLDNEW
« no previous file with comments | « base/BUILD.gn ('k') | rlz/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698