Remove a bunch of dead code from RenderLayer

Remove a bunch of dead code from RenderLayer

R=ojan@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/49eea2ecea4a830e21247fd4004ac0030f19e99b

[rafaelw, 2014-11-29 00:06:44]

rafaelw@chromium.org changed reviewers:
+ ojan@chromium.org

[ojan, 2014-11-29 01:48:15]

lgtm

https://codereview.chromium.org/735033003/diff/1/sky/engine/core/html/canvas/...
File sky/engine/core/html/canvas/WebGLRenderingContextBase.cpp (right):

https://codereview.chromium.org/735033003/diff/1/sky/engine/core/html/canvas/...
sky/engine/core/html/canvas/WebGLRenderingContextBase.cpp:951: // This seems
wrongs, but was already a no-op because hasAcceleratedCompositing returns false.
FIXME(sky) ?

I expect this bool doesn't do anything anymore. I also expect that WebGL is
completely broken right now. I don't think we've come to any conclusions about
whether WebGL makes sense for us or whether you should just iframe a mojo GL
component.

https://codereview.chromium.org/735033003/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBox.cpp (right):

https://codereview.chromium.org/735033003/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBox.cpp:926: bool flattenCompositingLayers =
view()->frameView() && view()->frameView()->paintBehavior() &
PaintBehaviorFlattenCompositingLayers;
FWIW, I would guess that a lot of these PaintBehavior* enum values are also
never set anymore (i.e. there is code that reads them like this, but they're
never actually set or returned).

https://codereview.chromium.org/735033003/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBox.cpp:926: bool flattenCompositingLayers =
view()->frameView() && view()->frameView()->paintBehavior() &
PaintBehaviorFlattenCompositingLayers;
FWIW, I would guess that a lot of these PaintBehavior* enum values are also
never set anymore (i.e. there is code that reads them like this, but they're
never actually set or returned).

https://codereview.chromium.org/735033003/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/735033003/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderObject.cpp:1212: // ??
Yup. This is right for now. All paint invalidation is WRT to the root now that
we don't have compositing. That'll probably change again when we fix painting
with iframes to work right. I think right now iframes will not paint correctly
between other elements (they'll always go on top?).

https://codereview.chromium.org/735033003/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderObject.cpp:1220: // ??
We can get rid of the concept now. We shouldn't have any special ancestors and
we don't have composited containers. I'd just make this a FIXME(sky).

[rafaelw, 2014-11-29 04:00:07]

Committed patchset #2 (id:20001) manually as
49eea2ecea4a830e21247fd4004ac0030f19e99b.