Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: sky/engine/core/rendering/RenderLayer.h

Issue 735033003: Remove a bunch of dead code from RenderLayer (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: cr comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderImage.cpp ('k') | sky/engine/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderLayer.h
diff --git a/sky/engine/core/rendering/RenderLayer.h b/sky/engine/core/rendering/RenderLayer.h
index 3d743c0a6c5572328b36d1cc61137b69975b3620..5f525154005fd0bf1e5f773243bedbe260e4e0e1 100644
--- a/sky/engine/core/rendering/RenderLayer.h
+++ b/sky/engine/core/rendering/RenderLayer.h
@@ -135,10 +135,6 @@ public:
bool isRootLayer() const { return m_isRootLayer; }
- // Notification from the renderer that its content changed (e.g. current frame of image changed).
- // Allows updates of layer content without invalidating paint.
- void contentChanged(ContentChangeType);
-
void updateLayerPositionsAfterLayout();
void updateTransformationMatrix();
@@ -147,7 +143,6 @@ public:
// Our current relative position offset.
const LayoutSize offsetForInFlowPosition() const;
- void blockSelectionGapsBoundsChanged();
void addBlockSelectionGapsBounds(const LayoutRect&);
void clearBlockSelectionGapsBounds();
void invalidatePaintForBlockSelectionGaps();
@@ -171,18 +166,6 @@ public:
RenderLayer* enclosingOverflowClipLayer(IncludeSelfOrNot = IncludeSelf) const;
- bool isPaintInvalidationContainer() const;
-
- // Do *not* call this method unless you know what you are dooing. You probably want to call enclosingCompositingLayerForPaintInvalidation() instead.
- // If includeSelf is true, may return this.
- RenderLayer* enclosingLayerWithCompositedLayerMapping(IncludeSelfOrNot) const;
-
- // Returns the enclosing layer root into which this layer paints, inclusive of this one. Note that the enclosing layer may or may not have its own
- // GraphicsLayer backing, but is nevertheless the root for a call to the RenderLayer::paint*() methods.
- RenderLayer* enclosingLayerForPaintInvalidation() const;
-
- RenderLayer* enclosingLayerForPaintInvalidationCrossingFrameBoundaries() const;
-
RenderLayer* enclosingFilterLayer(IncludeSelfOrNot = IncludeSelf) const;
bool hasAncestorWithFilterOutsets() const;
@@ -260,19 +243,13 @@ public:
// Only safe to call from RenderLayerModelObject::destroyLayer()
void operator delete(void*);
- bool hasCompositedMask() const;
- bool hasCompositedClippingMask() const;
bool needsCompositedScrolling() const { return m_scrollableArea && m_scrollableArea->needsCompositedScrolling(); }
- bool clipsCompositingDescendantsWithBorderRadius() const;
-
// Computes the position of the given render object in the space of |paintInvalidationContainer|.
// FIXME: invert the logic to have paint invalidation containers take care of painting objects into them, rather than the reverse.
// This will allow us to clean up this static method messiness.
static LayoutPoint positionFromPaintInvalidationContainer(const RenderObject*, const RenderLayerModelObject* paintInvalidationContainer, const PaintInvalidationState* = 0);
- static void mapRectToPaintBackingCoordinates(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect&);
-
// Adjusts the given rect (in the coordinate space of the RenderObject) to the coordinate space of |paintInvalidationContainer|'s GraphicsLayer backing.
static void mapRectToPaintInvalidationBacking(const RenderObject*, const RenderLayerModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState* = 0);
@@ -318,7 +295,6 @@ public:
Node* enclosingElement() const;
- bool scrollsWithViewport() const;
bool scrollsWithRespectTo(const RenderLayer*) const;
// FIXME: This should probably return a ScrollableArea but a lot of internal methods are mistakenly exposed.
@@ -405,7 +381,6 @@ public:
unsigned hasDescendantWithClipPath : 1;
};
- void setNeedsCompositingInputsUpdate();
bool childNeedsCompositingInputsUpdate() const { return m_childNeedsCompositingInputsUpdate; }
bool needsCompositingInputsUpdate() const
{
« no previous file with comments | « sky/engine/core/rendering/RenderImage.cpp ('k') | sky/engine/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698