Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 731323003: Revising cds2014 samples based on first round of feedback. (Closed)

Created:
6 years, 1 month ago by bradn
Modified:
6 years, 1 month ago
Reviewers:
jpmedley, binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revising cds2014 samples based on first round of feedback. Adding water.cc to commit history. Sample changed to reduce the need to understand row-major, changed doc to match. Changing python codelab to run locally. Pulling in new web devenv version with better copy paste. BUG=None R=jmedley@chromium.org TBR=binji@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a45f6b81f3cb191b3dc70eb77fc95e921709c34e

Patch Set 1 #

Patch Set 2 : add html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -30 lines) Patch
M native_client_sdk/doc_generated/cds2014/cpp.html View 1 3 chunks +4 lines, -6 lines 0 comments Download
M native_client_sdk/doc_generated/cds2014/python.html View 1 3 chunks +8 lines, -6 lines 0 comments Download
M native_client_sdk/doc_generated/sdk/download.html View 1 1 chunk +2 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/cds2014/cpp.rst View 3 chunks +3 lines, -9 lines 0 comments Download
M native_client_sdk/src/doc/cds2014/python.rst View 2 chunks +7 lines, -5 lines 0 comments Download
M native_client_sdk/src/doc/nacldev/setup_web.inc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
bradn
6 years, 1 month ago (2014-11-17 21:34:10 UTC) #1
jpmedley
LGTM
6 years, 1 month ago (2014-11-17 21:52:28 UTC) #2
bradn
going to land tbr from ben to get more group feedback, as he's out for ...
6 years, 1 month ago (2014-11-17 22:05:39 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a45f6b81f3cb191b3dc70eb77fc95e921709c34e Cr-Commit-Position: refs/heads/master@{#304492}
6 years, 1 month ago (2014-11-17 22:07:46 UTC) #4
bradn
Committed patchset #2 (id:20001) manually as a45f6b81f3cb191b3dc70eb77fc95e921709c34e (presubmit successful).
6 years, 1 month ago (2014-11-17 22:07:55 UTC) #5
binji
6 years, 1 month ago (2014-11-17 22:50:29 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698