Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: native_client_sdk/src/doc/cds2014/python.rst

Issue 731323003: Revising cds2014 samples based on first round of feedback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add html Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/doc/cds2014/cpp.rst ('k') | native_client_sdk/src/doc/nacldev/setup_web.inc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/doc/cds2014/python.rst
diff --git a/native_client_sdk/src/doc/cds2014/python.rst b/native_client_sdk/src/doc/cds2014/python.rst
index bc4b5d21224badcd090d69ea637bd5f4b9e9bf5c..07d235c618ae8b32e7b56852c62e4b51653eb12b 100644
--- a/native_client_sdk/src/doc/cds2014/python.rst
+++ b/native_client_sdk/src/doc/cds2014/python.rst
@@ -62,16 +62,18 @@ To see where things stand, deploy the sample like this::
make
-This will copy the sample to /tmp/differ (clobbering whatever is already
-there). It will also attempt to open the sample, but will be blocked by
-a popup blocker. Click on the URL to accept the popup.
+This will attempt to open the sample, but will be blocked by
+a popup blocker the first time. Click on the URL to accept the popup.
+It also clobbers /tmp/differ for good measure.
As you can see, this isn't quite what we're going for.
You'll want to modify diff.py, using the editor you selected earlier.
You'll probably want to consult the |difflib| documentation.
I would suggest you check out the HtmlDiff class and make use of
-the make_file member function. I would also suggest the splitlines
+the make_file member function. Note our goal is to create a
+full HTML diff, so the make_table function is insufficient.
+I would also suggest the splitlines
function may come in handy.
You can test diff.py manually as you would in a normal UNIX environment.
@@ -80,7 +82,7 @@ It can be run like this::
./diff.py before.txt after.txt out.html
Once everything is working diff.html will contain an html diff.
-Run `make` again to deploy and test the full app.
+After the initial `make` you can hit "Run" to test your changes.
Now get to it, and good luck!
« no previous file with comments | « native_client_sdk/src/doc/cds2014/cpp.rst ('k') | native_client_sdk/src/doc/nacldev/setup_web.inc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698