Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: tools/telemetry/telemetry/value/trace.py

Issue 731233003: Format profiler/trace files cloud url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add various unittests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/trace.py
diff --git a/tools/telemetry/telemetry/value/trace.py b/tools/telemetry/telemetry/value/trace.py
index 643f51578fd0bd02bd99b1eeaaba4144f112a63e..d33a284b7b1f31454a4969692410403318418bdf 100644
--- a/tools/telemetry/telemetry/value/trace.py
+++ b/tools/telemetry/telemetry/value/trace.py
@@ -50,6 +50,10 @@ class TraceValue(value_module.Value):
page_name = None
return 'TraceValue(%s, %s)' % (page_name, self.name)
+ @property
+ def cloud_url(self):
+ return self._cloud_url
+
def GetBuildbotDataType(self, output_context):
return None
@@ -82,6 +86,8 @@ class TraceValue(value_module.Value):
def AsDict(self):
d = super(TraceValue, self).AsDict()
d['file_id'] = self._file_handle.id
+ if self._cloud_url:
+ d['cloud_url'] = self._cloud_url
return d
def UploadToCloud(self, bucket):
@@ -100,3 +106,4 @@ class TraceValue(value_module.Value):
except cloud_storage.PermissionError as e:
logging.error('Cannot upload trace files to cloud storage due to '
' permission error: %s' % e.message)
+ self._cloud_url = 'error'
nednguyen 2014/11/20 02:04:11 I would rather not set _cloud_url.
Yufeng Shen (Slow to review) 2014/11/20 17:56:16 Done.

Powered by Google App Engine
This is Rietveld 408576698