Chromium Code Reviews| Index: tools/telemetry/telemetry/value/trace.py |
| diff --git a/tools/telemetry/telemetry/value/trace.py b/tools/telemetry/telemetry/value/trace.py |
| index 643f51578fd0bd02bd99b1eeaaba4144f112a63e..d33a284b7b1f31454a4969692410403318418bdf 100644 |
| --- a/tools/telemetry/telemetry/value/trace.py |
| +++ b/tools/telemetry/telemetry/value/trace.py |
| @@ -50,6 +50,10 @@ class TraceValue(value_module.Value): |
| page_name = None |
| return 'TraceValue(%s, %s)' % (page_name, self.name) |
| + @property |
| + def cloud_url(self): |
| + return self._cloud_url |
| + |
| def GetBuildbotDataType(self, output_context): |
| return None |
| @@ -82,6 +86,8 @@ class TraceValue(value_module.Value): |
| def AsDict(self): |
| d = super(TraceValue, self).AsDict() |
| d['file_id'] = self._file_handle.id |
| + if self._cloud_url: |
| + d['cloud_url'] = self._cloud_url |
| return d |
| def UploadToCloud(self, bucket): |
| @@ -100,3 +106,4 @@ class TraceValue(value_module.Value): |
| except cloud_storage.PermissionError as e: |
| logging.error('Cannot upload trace files to cloud storage due to ' |
| ' permission error: %s' % e.message) |
| + self._cloud_url = 'error' |
|
nednguyen
2014/11/20 02:04:11
I would rather not set _cloud_url.
Yufeng Shen (Slow to review)
2014/11/20 17:56:16
Done.
|