Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 731233003: Format profiler/trace files cloud url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add various unittests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/page_test_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/page_test_results_unittest.py b/tools/telemetry/telemetry/results/page_test_results_unittest.py
index 4de065b91c84fb10dfad2cd4a7958e03be0b2894..607f744d980bd79cd938e7fadcc2560c431c7833 100644
--- a/tools/telemetry/telemetry/results/page_test_results_unittest.py
+++ b/tools/telemetry/telemetry/results/page_test_results_unittest.py
@@ -7,10 +7,13 @@ import os
from telemetry.page import page_set
from telemetry.results import base_test_results_unittest
from telemetry.results import page_test_results
+from telemetry.timeline import tracing_timeline_data
from telemetry.value import failure
from telemetry.value import histogram
+from telemetry.value import profiler
from telemetry.value import scalar
from telemetry.value import skip
+from telemetry.value import trace
class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
@@ -182,3 +185,26 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
self.assertEquals(
[value1, value2, value3], results.all_page_specific_values)
+
+ def testTraceAndProfilerValue(self):
nednguyen 2014/11/20 02:04:11 Please split this into two tests: one for trace &
Yufeng Shen (Slow to review) 2014/11/20 17:56:15 Only test TraceValue now
+ results = page_test_results.PageTestResults()
+ results.WillRunPage(self.pages[0])
+ results.AddValue(trace.TraceValue(
+ None, tracing_timeline_data.TracingTimelineData({'test' : 1})))
+ results.AddValue(profiler.ProfilerValue(None, 'systrace', None))
+ results.DidRunPage(self.pages[0])
+
+ results.WillRunPage(self.pages[1])
+ results.AddValue(trace.TraceValue(
+ None, tracing_timeline_data.TracingTimelineData({'test' : 2})))
+ results.AddValue(profiler.ProfilerValue(None, 'v8', None))
+ results.DidRunPage(self.pages[1])
+
+ results.PrintSummary()
+
+ values = results.FindAllTraceValue()
+ self.assertEquals(2, len(values))
+ values = results.FindAllProfilerValue()
+ self.assertEquals(2, len(values))
+ self.assertEquals(values[0].profiler_name, 'systrace')
+ self.assertEquals(values[1].profiler_name, 'v8')

Powered by Google App Engine
This is Rietveld 408576698