Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: tools/telemetry/telemetry/value/profiler_unittest.py

Issue 731233003: Format profiler/trace files cloud url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add various unittests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/profiler_unittest.py
diff --git a/tools/telemetry/telemetry/value/trace_unittest.py b/tools/telemetry/telemetry/value/profiler_unittest.py
similarity index 53%
copy from tools/telemetry/telemetry/value/trace_unittest.py
copy to tools/telemetry/telemetry/value/profiler_unittest.py
index 6c9bda41584725dcd1301c29489ba97f22a43be2..06788fa137661b5b27dc0e4423e2316a26cc234a 100644
--- a/tools/telemetry/telemetry/value/trace_unittest.py
+++ b/tools/telemetry/telemetry/value/profiler_unittest.py
@@ -3,11 +3,13 @@
# found in the LICENSE file.
import os
+import tempfile
import unittest
from telemetry.page import page_set
-from telemetry.timeline import tracing_timeline_data
-from telemetry.value import trace
+from telemetry.util import cloud_storage
+from telemetry.util import file_handle
+from telemetry.value import profiler
class TestBase(unittest.TestCase):
def setUp(self):
@@ -22,10 +24,19 @@ class TestBase(unittest.TestCase):
class ValueTest(TestBase):
def testAsDict(self):
- v = trace.TraceValue(
- None, tracing_timeline_data.TracingTimelineData({'test' : 1}))
- fh_id = v.GetAssociatedFileHandle().id
-
+ v = profiler.ProfilerValue(None, 'trace', None)
d = v.AsDict()
- self.assertEqual(d['file_id'], fh_id)
+ self.assertEqual(d['profiler_name'], 'trace')
+
+ def testUploadToCloud(self):
+ try:
+ tf = tempfile.NamedTemporaryFile()
+ tf_handle = file_handle.FromTempFile(tf)
+ v = profiler.ProfilerValue(None, 'trace', tf_handle)
+ self.assertEqual(v.GetAssociatedFileHandle(), tf_handle)
+ bucket = cloud_storage.PUBLIC_BUCKET
+ v.UploadToCloud(bucket)
+ self.assertTrue(v.cloud_url)
+ finally:
+ tf.close()

Powered by Google App Engine
This is Rietveld 408576698