Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: tools/telemetry/telemetry/value/trace_unittest.py

Issue 731233003: Format profiler/trace files cloud url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add various unittests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/trace_unittest.py
diff --git a/tools/telemetry/telemetry/value/trace_unittest.py b/tools/telemetry/telemetry/value/trace_unittest.py
index 6c9bda41584725dcd1301c29489ba97f22a43be2..b6f9264147440bad1d27512968c0c71d11afd8f0 100644
--- a/tools/telemetry/telemetry/value/trace_unittest.py
+++ b/tools/telemetry/telemetry/value/trace_unittest.py
@@ -7,6 +7,7 @@ import unittest
from telemetry.page import page_set
from telemetry.timeline import tracing_timeline_data
+from telemetry.util import cloud_storage
from telemetry.value import trace
class TestBase(unittest.TestCase):
@@ -29,3 +30,10 @@ class ValueTest(TestBase):
d = v.AsDict()
self.assertEqual(d['file_id'], fh_id)
+
+ def testUploadToCloud(self):
+ v = trace.TraceValue(
+ None, tracing_timeline_data.TracingTimelineData({'test' : 1}))
+ bucket = cloud_storage.PUBLIC_BUCKET
+ v.UploadToCloud(bucket)
+ self.assertTrue(v.cloud_url)
nednguyen 2014/11/20 02:04:11 This test seems to does a network push anytime you
Yufeng Shen (Slow to review) 2014/11/20 17:56:16 changed to use system_stub
« tools/telemetry/telemetry/value/trace.py ('K') | « tools/telemetry/telemetry/value/trace.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698