Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 729683002: Make GrResourceCache2 responsible for calling release, abandon, and ~. (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@revrev
Visibility:
Public.

Description

Make GrResourceCache2 responsible for calling release, abandon, and ~. BUG=skia:2889 TBR=robertphillips@google.com NOTRY=true Committed: https://skia.googlesource.com/skia/+/12299ab7a1be5f4b99284ecf289d46107ef0a946

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : tiny cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -116 lines) Patch
M bench/GrResourceCacheBench.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M include/gpu/GrGpuResource.h View 5 chunks +22 lines, -28 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 3 chunks +18 lines, -16 lines 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 1 chunk +20 lines, -0 lines 0 comments Download
M src/gpu/GrResourceCache2.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrResourceCache2.cpp View 9 chunks +13 lines, -25 lines 0 comments Download
M src/gpu/gl/GrGLIndexBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLPath.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLPathRange.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLPathRange.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLStencilBuffer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLStencilBuffer.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLTexture.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLTextureRenderTarget.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLVertexBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 chunks +16 lines, -15 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
TBR b/c this fixes a big regression with ResCache2. It was holding a long-lived ref ...
6 years, 1 month ago (2014-11-14 21:00:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729683002/40001
6 years, 1 month ago (2014-11-14 21:01:08 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/719)
6 years, 1 month ago (2014-11-14 21:17:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729683002/40001
6 years, 1 month ago (2014-11-14 21:32:43 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/12299ab7a1be5f4b99284ecf289d46107ef0a946
6 years, 1 month ago (2014-11-14 21:33:14 UTC) #9
robertphillips
6 years, 1 month ago (2014-11-17 13:39:33 UTC) #10
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698