Move constants used by history component to history namespace

Move constants used by history component to history namespace.
Add history_constants.cc/h for history specific constants.

BUG=390953
TEST=unit_tests

Committed: https://crrev.com/b9f5bffad6a920c2f6139bc0e5f2bc91e8fc12b0
Cr-Commit-Position: refs/heads/master@{#306130}

[nshaik, 2014-11-15 09:35:29]

naiem.shaik@gmail.com changed reviewers:
+ sdefresne@chromium.org

[nshaik, 2014-11-15 09:35:53]

sdefresne:
PTAL

[sdefresne, 2014-11-19 17:46:18]

On 2014/11/15 09:35:53, nshaik wrote:
> sdefresne:
> PTAL

Sorry I've had a busy week and still didn't get time to review this CL. I'll
give it a shot tomorrow.

[sdefresne, 2014-11-21 14:11:41]

Please split the CL in two. One CL to address the constants that can be moved to
//components/history/core/browser/history_constant.h and another CL to deal with
HistoryService::CanAddURL.

https://codereview.chromium.org/722723005/diff/20001/chrome/browser/history/u...
File chrome/browser/history/url_utils.cc (right):

https://codereview.chromium.org/722723005/diff/20001/chrome/browser/history/u...
chrome/browser/history/url_utils.cc:90: bool CanAddURL(const GURL& url) {
We won't be able to move this function into the component (since it depends on
chrome and content namespace). I'm okay with having such a function living in
the embedder that can be used by the rest of the embedder code, but for the
component this won't work.

My recommendation is to have:

// in //components/history/core/browser/history_client.h
class HistoryClient {
 public:
  virtual bool CanAddURL(const GURL& url) const = 0;
};

// in //components/history/core/browser/top_sites_client.h
class TopSitesClient {
 public:
  virtual bool CanAddURL(const GURL& url) const = 0;
};

// in //chrome/browser/history/chrome_history_client.cc
bool ChromeHistoryClient::CanAddURL(const GURL& url) const {
  return history::CanAddURL(url);
}

// in //chrome/browser/history/chrome_top_sites_client.cc
bool ChromeTopSitesClient::CanAddURL(const GURL& url) const {
  return history::CanAddURL(url);
}

// in HistoryService
void HistoryService::AddPage(const history::HistoryAddPageArgs& add_page_args) {
  if (history_client_ && !history_client_->CanAddURL(add_page_args.url))
    return
  ...
}

[nshaik, 2014-11-25 22:08:45]

naiem.shaik@gmail.com changed reviewers:
+ grt@chromium.org, phajdan.jr@chromium.org

[nshaik, 2014-11-25 22:21:14]

naiem.shaik@gmail.com changed reviewers:
+ cpu@chromium.org, jochen@chromium.org

[nshaik, 2014-11-25 22:21:14]

PTAL.

@cpu:
chrome/browser/diagnostics/

@jochen:
chrome/common/

@sdefresne:
chrome/browser/history
components/history

@phajdan.jr:
chrome/test/base/

https://codereview.chromium.org/722723005/diff/20001/chrome/browser/history/u...
File chrome/browser/history/url_utils.cc (right):

https://codereview.chromium.org/722723005/diff/20001/chrome/browser/history/u...
chrome/browser/history/url_utils.cc:90: bool CanAddURL(const GURL& url) {
Will do it in the other CL.

[jochen (gone - plz use gerrit), 2014-11-25 22:45:48]

are you committed to move the entire history system to a component? this effort
seems to be currently not owned by anybody and unless you want to move
everything, we shouldn't shouldn't add more bits

[sdefresne, 2014-11-26 14:30:15]

LGTM

On 2014/11/25 22:45:48, jochen (slow) wrote:
> are you committed to move the entire history system to a component? this
effort
> seems to be currently not owned by anybody and unless you want to move
> everything, we shouldn't shouldn't add more bits

Chrome on iOS team is committed to move history system to a component and I am
leading this effort. The umbrella bug can be found here:
https://code.google.com/p/chromium/issues/detail?id=370850 and is currently
owned by me. jochen: is there an other issue that I should own?

[Paweł Hajdan Jr., 2014-11-26 15:40:51]

chrome/test/base LGTM

[jochen (gone - plz use gerrit), 2014-11-26 15:53:02]

chrome/common lgtm

sdefresne, I've added you to the relevant thread

[nshaik, 2014-11-27 17:58:31]

The CQ bit was checked by naiem.shaik@gmail.com

[commit-bot: I haz the power, 2014-11-27 17:58:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/722723005/40001

[commit-bot: I haz the power, 2014-11-27 18:21:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-27 18:21:10]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[nshaik, 2014-11-27 19:02:10]

The CQ bit was checked by naiem.shaik@gmail.com

[commit-bot: I haz the power, 2014-11-27 19:02:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/722723005/60001

[commit-bot: I haz the power, 2014-11-27 19:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-27 19:06:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nshaik, 2014-11-27 20:36:17]

naiem.shaik@gmail.com changed reviewers:
+ tzik@chromium.org

[nshaik, 2014-11-27 20:37:08]

PTAL.
@tzik for:
storage/browser/fileapi/

[tzik, 2014-11-29 16:33:12]

lgtm

[nshaik, 2014-11-30 03:48:24]

The CQ bit was checked by naiem.shaik@gmail.com

[commit-bot: I haz the power, 2014-11-30 03:48:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/722723005/80001

[commit-bot: I haz the power, 2014-11-30 03:54:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-30 03:54:26]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[nshaik, 2014-11-30 08:12:44]

The CQ bit was checked by naiem.shaik@gmail.com

[commit-bot: I haz the power, 2014-11-30 08:13:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/722723005/100001

[commit-bot: I haz the power, 2014-11-30 09:02:43]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-11-30 09:03:27]

Patchset 6 (id:??) landed as
https://crrev.com/b9f5bffad6a920c2f6139bc0e5f2bc91e8fc12b0
Cr-Commit-Position: refs/heads/master@{#306130}