chrome/common/chrome_constants.h - Issue 722723005: Move constants used by history component to history namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_constants.h

Issue 722723005: Move constants used by history component to history namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android build failures Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc ('k') | chrome/common/chrome_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/chrome_constants.h

diff --git a/chrome/common/chrome_constants.h b/chrome/common/chrome_constants.h

index 869f42b0affb0dda0580f54141f2d57ccc0478d6..d65e5fdbee4608643224cef1b35f607778483c27 100644

--- a/chrome/common/chrome_constants.h

+++ b/chrome/common/chrome_constants.h

@@ -62,10 +62,6 @@ extern const base::FilePath::CharType kGuestProfileDir[];

extern const wchar_t kBrowserResourcesDll[];

// filenames

-#if defined(OS_ANDROID)

-extern const base::FilePath::CharType kAndroidCacheFilename[];

-#endif

-extern const base::FilePath::CharType kArchivedHistoryFilename[];

extern const base::FilePath::CharType kCacheDirname[];

extern const base::FilePath::CharType kChannelIDFilename[];

extern const base::FilePath::CharType kCookieFilename[];

@@ -73,10 +69,8 @@ extern const base::FilePath::CharType kCRLSetFilename[];

extern const base::FilePath::CharType kCustomDictionaryFileName[];

extern const base::FilePath::CharType kExtensionActivityLogFilename[];

extern const base::FilePath::CharType kExtensionsCookieFilename[];

-extern const base::FilePath::CharType kFaviconsFilename[];

extern const base::FilePath::CharType kFirstRunSentinel[];

extern const base::FilePath::CharType kGCMStoreDirname[];

-extern const base::FilePath::CharType kHistoryFilename[];

extern const base::FilePath::CharType kJumpListIconDirname[];

extern const base::FilePath::CharType kLocalStateFilename[];

extern const base::FilePath::CharType kLocalStorePoolName[];