chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc - Issue 722723005: Move constants used by history component to history namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

Issue 722723005: Move constants used by history component to history namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android build failures Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

index 9d257b26d0def84431b679288b38dfc975873d34..ced861c154eb71497824d240c8362e2764b7e1b7 100644

--- a/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

@@ -28,6 +28,7 @@

#include "chrome/test/base/testing_pref_service_syncable.h"

#include "chrome/test/base/testing_profile.h"

#include "chrome/test/base/testing_profile_manager.h"

+#include "components/history/core/browser/history_constants.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "content/public/test/test_utils.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -41,7 +42,7 @@ KeyedService* BuildHistoryService(content::BrowserContext* context) {

// Delete the file before creating the service.

base::FilePath history_path(

- profile->GetPath().Append(chrome::kHistoryFilename));

+ profile->GetPath().Append(history::kHistoryFilename));

if (!base::DeleteFile(history_path, false) ||

base::PathExists(history_path)) {

ADD_FAILURE() << "failed to delete history db file "

« no previous file with comments | « chrome/browser/history/history_unittest.cc ('k') | chrome/common/chrome_constants.h » ('j') | no next file with comments »