Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: chrome/browser/history/android/android_urls_database_unittest.cc

Issue 722723005: Move constants used by history component to history namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android build failures Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/history/android/android_urls_database.h" 5 #include "chrome/browser/history/android/android_urls_database.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "chrome/browser/history/history_database.h" 10 #include "chrome/browser/history/history_database.h"
11 #include "chrome/browser/history/history_unittest_base.h" 11 #include "chrome/browser/history/history_unittest_base.h"
12 #include "chrome/common/chrome_constants.h" 12 #include "chrome/common/chrome_constants.h"
13 #include "chrome/common/chrome_paths.h" 13 #include "chrome/common/chrome_paths.h"
14 #include "chrome/test/base/testing_profile.h" 14 #include "chrome/test/base/testing_profile.h"
15 #include "components/history/core/browser/history_constants.h"
15 16
16 namespace history { 17 namespace history {
17 18
18 class AndroidURLsMigrationTest : public HistoryUnitTestBase { 19 class AndroidURLsMigrationTest : public HistoryUnitTestBase {
19 public: 20 public:
20 AndroidURLsMigrationTest() { 21 AndroidURLsMigrationTest() {
21 } 22 }
22 virtual ~AndroidURLsMigrationTest() {} 23 virtual ~AndroidURLsMigrationTest() {}
23 24
24 protected: 25 protected:
25 virtual void SetUp() { 26 virtual void SetUp() {
26 profile_.reset(new TestingProfile); 27 profile_.reset(new TestingProfile);
27 28
28 base::FilePath data_path; 29 base::FilePath data_path;
29 ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &data_path)); 30 ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &data_path));
30 data_path = data_path.AppendASCII("History"); 31 data_path = data_path.AppendASCII("History");
31 32
32 history_db_name_ = profile_->GetPath().Append(chrome::kHistoryFilename); 33 history_db_name_ = profile_->GetPath().Append(kHistoryFilename);
33 // Set up history as they would be before migration. 34 // Set up history as they would be before migration.
34 ASSERT_NO_FATAL_FAILURE( 35 ASSERT_NO_FATAL_FAILURE(
35 ExecuteSQLScript(data_path.AppendASCII("history.21.sql"), 36 ExecuteSQLScript(data_path.AppendASCII("history.21.sql"),
36 history_db_name_)); 37 history_db_name_));
37 } 38 }
38 39
39 protected: 40 protected:
40 base::FilePath history_db_name_; 41 base::FilePath history_db_name_;
41 scoped_ptr<TestingProfile> profile_; 42 scoped_ptr<TestingProfile> profile_;
42 }; 43 };
(...skipping 15 matching lines...) Expand all
58 59
59 ASSERT_TRUE(statement.Step()); 60 ASSERT_TRUE(statement.Step());
60 EXPECT_EQ(4, statement.ColumnInt64(0)); 61 EXPECT_EQ(4, statement.ColumnInt64(0));
61 EXPECT_EQ("www.google.com/", statement.ColumnString(2)); 62 EXPECT_EQ("www.google.com/", statement.ColumnString(2));
62 EXPECT_EQ(3, statement.ColumnInt64(1)); 63 EXPECT_EQ(3, statement.ColumnInt64(1));
63 64
64 EXPECT_FALSE(statement.Step()); 65 EXPECT_FALSE(statement.Step());
65 } 66 }
66 67
67 } // namespace history 68 } // namespace history
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698